Commit 44cc0305 authored by Clement Ho's avatar Clement Ho

Merge branch '57582-dropdown-icon-misalignment-on-issues-list-on-mobile-screen' into 'master'

Fix alignment of dropdown icon on issuable on mobile

Closes #57582

See merge request gitlab-org/gitlab-ce!25205
parents 0b0a04fd 2e182f33
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
.dropdown.inline.prepend-left-10.issue-sort-dropdown .dropdown.inline.prepend-left-10.issue-sort-dropdown
.btn-group{ role: 'group' } .btn-group{ role: 'group' }
.btn-group{ role: 'group' } .btn-group{ role: 'group' }
%button.dropdown-toggle{ type: 'button', data: { toggle: 'dropdown', display: 'static' }, class: 'btn btn-default' } %button.dropdown-menu-toggle{ type: 'button', data: { toggle: 'dropdown', display: 'static' }, class: 'btn btn-default' }
= sort_title = sort_title
= icon('chevron-down') = icon('chevron-down')
%ul.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort %ul.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
......
---
title: Fix alignment of dropdown icon on issuable on mobile
merge_request: 25205
author: Takuya Noguchi
type: fixed
...@@ -59,13 +59,6 @@ describe 'Visual tokens', :js do ...@@ -59,13 +59,6 @@ describe 'Visual tokens', :js do
expect(page).to have_css('#js-dropdown-author', visible: false) expect(page).to have_css('#js-dropdown-author', visible: false)
end end
it 'ends editing mode when scroll container is clicked' do
find('.scroll-container').click
expect_filtered_search_input_empty
expect(page).to have_css('#js-dropdown-author', visible: false)
end
describe 'selecting different author from dropdown' do describe 'selecting different author from dropdown' do
before do before do
filter_author_dropdown.find('.filter-dropdown-item .dropdown-light-content', text: "@#{user_rock.username}").click filter_author_dropdown.find('.filter-dropdown-item .dropdown-light-content', text: "@#{user_rock.username}").click
...@@ -109,13 +102,6 @@ describe 'Visual tokens', :js do ...@@ -109,13 +102,6 @@ describe 'Visual tokens', :js do
expect(page).to have_css('#js-dropdown-assignee', visible: false) expect(page).to have_css('#js-dropdown-assignee', visible: false)
end end
it 'ends editing mode when scroll container is clicked' do
find('.scroll-container').click
expect_filtered_search_input_empty
expect(page).to have_css('#js-dropdown-assignee', visible: false)
end
describe 'selecting static option from dropdown' do describe 'selecting static option from dropdown' do
before do before do
find("#js-dropdown-assignee").find('.filter-dropdown-item', text: 'None').click find("#js-dropdown-assignee").find('.filter-dropdown-item', text: 'None').click
...@@ -167,13 +153,6 @@ describe 'Visual tokens', :js do ...@@ -167,13 +153,6 @@ describe 'Visual tokens', :js do
expect_filtered_search_input_empty expect_filtered_search_input_empty
expect(page).to have_css('#js-dropdown-milestone', visible: false) expect(page).to have_css('#js-dropdown-milestone', visible: false)
end end
it 'ends editing mode when scroll container is clicked' do
find('.scroll-container').click
expect_filtered_search_input_empty
expect(page).to have_css('#js-dropdown-milestone', visible: false)
end
end end
describe 'editing label token' do describe 'editing label token' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment