Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
44e545be
Commit
44e545be
authored
Apr 12, 2021
by
Neil McCorrison
Committed by
Luke Duncalfe
Apr 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Small text updates on the SAST Config UI page
https://gitlab.com/gitlab-org/gitlab/-/issues/326417
parent
b68039ed
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
25 additions
and
20 deletions
+25
-20
app/validators/json_schemas/security_ci_configuration_schemas/sast_ui_schema.json
...mas/security_ci_configuration_schemas/sast_ui_schema.json
+16
-16
changelogs/unreleased/326417-small-text-updates-on-sast-config-ui-page.yml
...ased/326417-small-text-updates-on-sast-config-ui-page.yml
+5
-0
spec/graphql/types/project_type_spec.rb
spec/graphql/types/project_type_spec.rb
+2
-2
spec/services/security/ci_configuration/sast_parser_service_spec.rb
...ces/security/ci_configuration/sast_parser_service_spec.rb
+2
-2
No files found.
app/validators/json_schemas/security_ci_configuration_schemas/sast_ui_schema.json
View file @
44e545be
...
...
@@ -51,36 +51,36 @@
],
"analyzers"
:
[
{
"name"
:
"b
rakeman
"
,
"label"
:
"B
rakeman
"
,
"name"
:
"b
andit
"
,
"label"
:
"B
andit
"
,
"enabled"
:
true
,
"description"
:
"
Ruby on Rails
"
,
"description"
:
"
Python
"
,
"variables"
:
[
{
"field"
:
"SAST_B
RAKEMAN_LEVEL
"
,
"label"
:
"
Brakeman confidence level.
"
,
"field"
:
"SAST_B
ANDIT_EXCLUDED_PATHS
"
,
"label"
:
"
Paths to exclude from scan
"
,
"type"
:
"string"
,
"default_value"
:
"
1
"
,
"default_value"
:
""
,
"value"
:
""
,
"size"
:
"SMALL"
,
"description"
:
"
Ignore Brakeman vulnerabilities under given confidence level. Integer, 1=Low, 2=Medium, 3=High.
"
"description"
:
"
Comma-separated list of paths to exclude from scan. Uses Python’s 'fnmatch' syntax; For example: '*/tests/*, */venv/*'
"
}
]
},
{
"name"
:
"b
andit
"
,
"label"
:
"B
andit
"
,
"name"
:
"b
rakeman
"
,
"label"
:
"B
rakeman
"
,
"enabled"
:
true
,
"description"
:
"
Python
"
,
"description"
:
"
Ruby on Rails
"
,
"variables"
:
[
{
"field"
:
"SAST_B
ANDIT_EXCLUDED_PATHS
"
,
"label"
:
"
Paths to exclude from scan.
"
,
"field"
:
"SAST_B
RAKEMAN_LEVEL
"
,
"label"
:
"
Brakeman confidence level
"
,
"type"
:
"string"
,
"default_value"
:
""
,
"default_value"
:
"
1
"
,
"value"
:
""
,
"size"
:
"SMALL"
,
"description"
:
"
Comma-separated list of paths to exclude from scan. Uses Python’s 'fnmatch' syntax; For example: '*/tests/*, */venv/*'
"
"description"
:
"
Ignore Brakeman vulnerabilities under given confidence level. Integer, 1=Low, 2=Medium, 3=High.
"
}
]
},
...
...
@@ -110,7 +110,7 @@
},
{
"name"
:
"kubesec"
,
"label"
:
"
k
ubesec"
,
"label"
:
"
K
ubesec"
,
"enabled"
:
true
,
"description"
:
"Kubernetes manifests, Helm Charts"
,
"variables"
:
[]
...
...
@@ -124,7 +124,7 @@
},
{
"name"
:
"gosec"
,
"label"
:
"Go
lang Security Checker
"
,
"label"
:
"Go
sec
"
,
"enabled"
:
true
,
"description"
:
"Go"
,
"variables"
:
[
...
...
changelogs/unreleased/326417-small-text-updates-on-sast-config-ui-page.yml
0 → 100644
View file @
44e545be
---
title
:
Small text updates on the SAST Config UI page
merge_request
:
58188
author
:
type
:
changed
spec/graphql/types/project_type_spec.rb
View file @
44e545be
...
...
@@ -125,8 +125,8 @@ RSpec.describe GitlabSchema.types['Project'] do
it
"returns the project's sast configuration for analyzer variables"
do
analyzer
=
subject
.
dig
(
'data'
,
'project'
,
'sastCiConfiguration'
,
'analyzers'
,
'nodes'
).
first
expect
(
analyzer
[
'name'
]).
to
eq
(
'b
rakeman
'
)
expect
(
analyzer
[
'label'
]).
to
eq
(
'B
rakeman
'
)
expect
(
analyzer
[
'name'
]).
to
eq
(
'b
andit
'
)
expect
(
analyzer
[
'label'
]).
to
eq
(
'B
andit
'
)
expect
(
analyzer
[
'enabled'
]).
to
eq
(
true
)
end
...
...
spec/services/security/ci_configuration/sast_parser_service_spec.rb
View file @
44e545be
...
...
@@ -12,8 +12,8 @@ RSpec.describe Security::CiConfiguration::SastParserService do
let
(
:sast_analyzer_image_tag
)
{
configuration
[
'global'
][
2
]
}
let
(
:sast_pipeline_stage
)
{
configuration
[
'pipeline'
][
0
]
}
let
(
:sast_search_max_depth
)
{
configuration
[
'pipeline'
][
1
]
}
let
(
:b
rakeman
)
{
configuration
[
'analyzers'
][
0
]
}
let
(
:b
andit
)
{
configuration
[
'analyzers'
][
1
]
}
let
(
:b
andit
)
{
configuration
[
'analyzers'
][
0
]
}
let
(
:b
rakeman
)
{
configuration
[
'analyzers'
][
1
]
}
let
(
:sast_brakeman_level
)
{
brakeman
[
'variables'
][
0
]
}
it
'parses the configuration for SAST'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment