Commit 4590b9f9 authored by http://jneen.net/'s avatar http://jneen.net/ Committed by Bryce Johnson

use fully qualified constants and only respond to json reqs

parent 2a2aaca8
...@@ -493,7 +493,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController ...@@ -493,7 +493,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController
return render_404 return render_404
end end
MergeRequests::ApprovalService. ::MergeRequests::ApprovalService.
new(project, current_user). new(project, current_user).
execute(@merge_request) execute(@merge_request)
...@@ -505,8 +505,8 @@ class Projects::MergeRequestsController < Projects::ApplicationController ...@@ -505,8 +505,8 @@ class Projects::MergeRequestsController < Projects::ApplicationController
end end
def unapprove def unapprove
if merge_request.has_approved?(current_user) if @merge_request.has_approved?(current_user)
MergeRequests::RemoveApprovalService. ::MergeRequests::RemoveApprovalService.
new(project, current_user). new(project, current_user).
execute(@merge_request) execute(@merge_request)
end end
...@@ -517,7 +517,12 @@ class Projects::MergeRequestsController < Projects::ApplicationController ...@@ -517,7 +517,12 @@ class Projects::MergeRequestsController < Projects::ApplicationController
protected protected
def render_approvals_json def render_approvals_json
render json: API::Entities::MergeRequestApprovals.new(@merge_request) respond_to do |format|
format.json do
entity = API::Entities::MergeRequestApprovals.new(@merge_request.reload, current_user: current_user)
render json: entity
end
end
end end
def selected_target_project def selected_target_project
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment