Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
48ca2dc6
Commit
48ca2dc6
authored
Dec 20, 2018
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove oldrev and newrev nil-checks that are now unnecessary
parent
3a0ae96c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
2 deletions
+6
-2
lib/gitlab/checks/base_checker.rb
lib/gitlab/checks/base_checker.rb
+5
-1
lib/gitlab/checks/diff_check.rb
lib/gitlab/checks/diff_check.rb
+1
-1
No files found.
lib/gitlab/checks/base_checker.rb
View file @
48ca2dc6
...
...
@@ -18,12 +18,16 @@ module Gitlab
private
def
creation?
Gitlab
::
Git
.
blank_ref?
(
oldrev
)
end
def
deletion?
Gitlab
::
Git
.
blank_ref?
(
newrev
)
end
def
update?
!
Gitlab
::
Git
.
blank_ref?
(
oldrev
)
&&
!
deletion?
!
creation?
&&
!
deletion?
end
def
updated_from_web?
...
...
lib/gitlab/checks/diff_check.rb
View file @
48ca2dc6
...
...
@@ -11,7 +11,7 @@ module Gitlab
}.
freeze
def
validate!
return
if
deletion?
||
newrev
.
nil?
return
if
deletion?
return
unless
should_run_diff_validations?
return
if
commits
.
empty?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment