Fix Incident sidebar on issue boards

Review feedback

app/assets/javascripts/boards/graphql/issue.fragment.graphql

-#import "~/graphql_shared/fragments/milestone.fragment.graphql"
-#import "~/graphql_shared/fragments/user.fragment.graphql"
+#import "~/graphql_shared/fragments/issue.fragment.graphql"
 
-fragment IssueNode on Issue {
+fragment Issue on Issue {
   id
-  iid
-  title
-  referencePath: reference(full: true)
-  dueDate
-  timeEstimate
-  totalTimeSpent
-  humanTimeEstimate
-  humanTotalTimeSpent
-  emailsDisabled
-  confidential
-  hidden
-  webUrl
-  relativePosition
-  type
-  severity
-  milestone {
-    ...MilestoneFragment
-  }
-  assignees {
-    nodes {
-      ...User
-    }
-  }
-  labels {
-    nodes {
-      id
-      title
-      color
-      description
-    }
-  }
+  ...IssueNode
 }

app/assets/javascripts/boards/graphql/issue_create.mutation.graphql

@@ -3,7 +3,7 @@
 mutation CreateIssue($input: CreateIssueInput!) {
   createIssue(input: $input) {
     issue {
-      ...IssueNode
+      ...Issue
     }
     errors
   }

app/assets/javascripts/boards/graphql/issue_move_list.mutation.graphql

@@ -21,7 +21,7 @@ mutation issueMoveList(
     }
   ) {
     issue {
-      ...IssueNode
+      ...Issue
     }
     errors
   }

app/assets/javascripts/boards/graphql/lists_issues.query.graphql

@@ -22,7 +22,7 @@ query BoardListsEE(
           issues(first: $first, filters: $filters, after: $after) {
             edges {
               node {
-                ...IssueNode
+                ...Issue
               }
             }
             pageInfo {
@@ -46,7 +46,7 @@ query BoardListsEE(
           issues(first: $first, filters: $filters, after: $after) {
             edges {
               node {
-                ...IssueNode
+                ...Issue
               }
             }
             pageInfo {

app/assets/javascripts/graphql_shared/fragments/issue.fragment.graphql

+#import "~/graphql_shared/fragments/milestone.fragment.graphql"
+#import "~/graphql_shared/fragments/user.fragment.graphql"
+
+fragment IssueNode on Issue {
+  id
+  iid
+  title
+  referencePath: reference(full: true)
+  dueDate
+  timeEstimate
+  totalTimeSpent
+  humanTimeEstimate
+  humanTotalTimeSpent
+  emailsDisabled
+  confidential
+  hidden
+  webUrl
+  relativePosition
+  type
+  severity
+  milestone {
+    ...MilestoneFragment
+  }
+  assignees {
+    nodes {
+      ...User
+    }
+  }
+  labels {
+    nodes {
+      id
+      title
+      color
+      description
+    }
+  }
+}

ee/app/assets/javascripts/boards/graphql/issue.fragment.graphql

-#import "~/graphql_shared/fragments/milestone.fragment.graphql"
-#import "~/graphql_shared/fragments/user.fragment.graphql"
+#import "~/graphql_shared/fragments/issue.fragment.graphql"
 
-fragment IssueNode on Issue {
+fragment Issue on Issue {
+  ...IssueNode
   id
-  iid
-  title
-  referencePath: reference(full: true)
-  dueDate
-  timeEstimate
-  totalTimeSpent
-  humanTimeEstimate
-  humanTotalTimeSpent
   weight
-  confidential
-  hidden
-  webUrl
   blocked
   blockedByCount
-  relativePosition
-  type
-  severity
   epic {
     id
   }
-  assignees {
-    nodes {
-      ...User
-    }
-  }
-  milestone {
-    ...MilestoneFragment
-  }
   iteration {
     id
     title
@@ -39,12 +17,4 @@ fragment IssueNode on Issue {
       title
     }
   }
-  labels {
-    nodes {
-      id
-      title
-      color
-      description
-    }
-  }
 }

ee/app/assets/javascripts/boards/graphql/issue_move_list.mutation.graphql

@@ -23,7 +23,7 @@ mutation issueMoveListEE(
     }
   ) {
     issue {
-      ...IssueNode
+      ...Issue
     }
     errors
   }

ee/spec/frontend/boards/components/board_content_sidebar_spec.js

@@ -97,7 +97,7 @@ describe('ee/BoardContentSidebar', () => {
     });
 
     it('matches the snapshot', () => {
-      expect(wrapper.find(GlDrawer).element).toMatchSnapshot();
+      expect(wrapper.findComponent(GlDrawer).element).toMatchSnapshot();
     });
   });
 
@@ -110,7 +110,7 @@ describe('ee/BoardContentSidebar', () => {
     });
 
     it('matches the snapshot', () => {
-      expect(wrapper.find(GlDrawer).element).toMatchSnapshot();
+      expect(wrapper.findComponent(GlDrawer).element).toMatchSnapshot();
     });
   });
 });

spec/frontend/boards/components/board_content_sidebar_spec.js

@@ -97,7 +97,7 @@ describe('BoardContentSidebar', () => {
   });
 
   it('confirms we render MountingPortal', () => {
-    expect(wrapper.find(MountingPortal).props()).toMatchObject({
+    expect(wrapper.findComponent(MountingPortal).props()).toMatchObject({
       mountTo: '#js-right-sidebar-portal',
       append: true,
       name: 'board-content-sidebar',
@@ -143,7 +143,7 @@ describe('BoardContentSidebar', () => {
   });
 
   it('does not render SidebarSeverity', () => {
-    expect(wrapper.find(SidebarSeverity).exists()).toBe(false);
+    expect(wrapper.findComponent(SidebarSeverity).exists()).toBe(false);
   });
 
   describe('when we emit close', () => {
@@ -175,7 +175,7 @@ describe('BoardContentSidebar', () => {
     });
 
     it('renders SidebarSeverity', () => {
-      expect(wrapper.find(SidebarSeverity).exists()).toBe(true);
+      expect(wrapper.findComponent(SidebarSeverity).exists()).toBe(true);
     });
   });
 });