Commit 4985ba22 authored by Pawel Chojnacki's avatar Pawel Chojnacki

Small review fixes

parent b8a50050
......@@ -10,7 +10,7 @@
= link_to s_('PrometheusService|More information'), help_page_path('user/project/integrations/prometheus')
.col-lg-9
.panel.panel-default.custom-monitored-metrics.js-panel-custom-monitored-metrics{ data: { "active-custom-metrics" => "#{project_prometheus_metrics_path(@project, :json)}" } }
.panel.panel-default.custom-monitored-metrics.js-panel-custom-monitored-metrics{ data: { active_custom_metrics: project_prometheus_metrics_path(@project, :json) } }
.panel-heading
%h3.panel-title
= s_('PrometheusService|Custom application metrics')
......@@ -28,7 +28,7 @@
= link_to s_('PrometheusService|New metric'), new_project_prometheus_metric_path(@project), class: 'btn btn-success'
%ul.list-unstyled.metrics-list.hidden.js-custom-metrics-list
.panel.panel-default.js-panel-monitored-metrics{ data: { "active-metrics" => "#{active_common_project_prometheus_metrics_path(@project, :json)}" } }
.panel.panel-default.js-panel-monitored-metrics{ data: { active_metrics: active_common_project_prometheus_metrics_path(@project, :json) } }
.panel-heading
%h3.panel-title
= s_('PrometheusService|Common metrics')
......
......@@ -104,7 +104,7 @@ describe Projects::Prometheus::MetricsController do
context 'format json' do
let!(:metric) { create(:prometheus_metric, project: project) }
it 'remove the metric' do
it 'destroys the metric' do
delete :destroy, project_params(id: metric.id, format: :json)
expect(response).to have_gitlab_http_status(200)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment