Commit 4a7cc998 authored by charlie ablett's avatar charlie ablett

Merge branch 'fix_epic_id_type' into 'master'

Use stricter epic ID type definition

See merge request gitlab-org/gitlab!45460
parents c5d9677e 3c9deebc
...@@ -1269,11 +1269,10 @@ RSpec/TimecopTravel: ...@@ -1269,11 +1269,10 @@ RSpec/TimecopTravel:
- 'spec/workers/concerns/reenqueuer_spec.rb' - 'spec/workers/concerns/reenqueuer_spec.rb'
- 'spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb'
# Offense count: 43 # Offense count: 21
Graphql/IDType: Graphql/IDType:
Exclude: Exclude:
- 'ee/app/graphql/ee/mutations/issues/update.rb' - 'ee/app/graphql/ee/mutations/issues/update.rb'
- 'ee/app/graphql/ee/types/boards/board_issue_input_base_type.rb'
- 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/iterations/update.rb'
- 'ee/app/graphql/resolvers/iterations_resolver.rb' - 'ee/app/graphql/resolvers/iterations_resolver.rb'
- 'app/graphql/mutations/boards/issues/issue_move_list.rb' - 'app/graphql/mutations/boards/issues/issue_move_list.rb'
......
...@@ -1695,7 +1695,7 @@ input BoardIssueInput { ...@@ -1695,7 +1695,7 @@ input BoardIssueInput {
""" """
Filter by epic ID. Incompatible with epicWildcardId Filter by epic ID. Incompatible with epicWildcardId
""" """
epicId: ID epicId: EpicID
""" """
Filter by epic ID wildcard. Incompatible with epicId Filter by epic ID wildcard. Incompatible with epicId
...@@ -12568,7 +12568,7 @@ input NegatedBoardIssueInput { ...@@ -12568,7 +12568,7 @@ input NegatedBoardIssueInput {
""" """
Filter by epic ID. Incompatible with epicWildcardId Filter by epic ID. Incompatible with epicWildcardId
""" """
epicId: ID epicId: EpicID
""" """
Filter by label name Filter by label name
......
...@@ -4518,7 +4518,7 @@ ...@@ -4518,7 +4518,7 @@
"description": "Filter by epic ID. Incompatible with epicWildcardId", "description": "Filter by epic ID. Incompatible with epicWildcardId",
"type": { "type": {
"kind": "SCALAR", "kind": "SCALAR",
"name": "ID", "name": "EpicID",
"ofType": null "ofType": null
}, },
"defaultValue": null "defaultValue": null
...@@ -36941,7 +36941,7 @@ ...@@ -36941,7 +36941,7 @@
"description": "Filter by epic ID. Incompatible with epicWildcardId", "description": "Filter by epic ID. Incompatible with epicWildcardId",
"type": { "type": {
"kind": "SCALAR", "kind": "SCALAR",
"name": "ID", "name": "EpicID",
"ofType": null "ofType": null
}, },
"defaultValue": null "defaultValue": null
...@@ -7,7 +7,7 @@ module EE ...@@ -7,7 +7,7 @@ module EE
extend ActiveSupport::Concern extend ActiveSupport::Concern
prepended do prepended do
argument :epic_id, GraphQL::ID_TYPE, argument :epic_id, ::Types::GlobalIDType[::Epic],
required: false, required: false,
description: 'Filter by epic ID. Incompatible with epicWildcardId' description: 'Filter by epic ID. Incompatible with epicWildcardId'
......
---
title: Update epic ID type in board issue mutations to be more specific
merge_request: 45460
author:
type: changed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment