Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4adabdc0
Commit
4adabdc0
authored
Jun 09, 2021
by
Jaime Martinez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove feature flag release_mr_issue_urls
Changelog: other
parent
987ce34c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
56 deletions
+1
-56
app/presenters/release_presenter.rb
app/presenters/release_presenter.rb
+1
-9
config/feature_flags/development/release_mr_issue_urls.yml
config/feature_flags/development/release_mr_issue_urls.yml
+0
-8
spec/presenters/release_presenter_spec.rb
spec/presenters/release_presenter_spec.rb
+0
-39
No files found.
app/presenters/release_presenter.rb
View file @
4adabdc0
...
...
@@ -26,31 +26,27 @@ class ReleasePresenter < Gitlab::View::Presenter::Delegated
end
def
opened_merge_requests_url
return
unless
release_mr_issue_urls_available?
project_merge_requests_url
(
project
,
params_for_issues_and_mrs
)
end
def
merged_merge_requests_url
return
unless
release_mr_issue_urls_available?
project_merge_requests_url
(
project
,
params_for_issues_and_mrs
(
state:
'merged'
))
end
def
closed_merge_requests_url
return
unless
release_mr_issue_urls_available?
project_merge_requests_url
(
project
,
params_for_issues_and_mrs
(
state:
'closed'
))
end
def
opened_issues_url
return
unless
release_mr_issue_urls_available?
project_issues_url
(
project
,
params_for_issues_and_mrs
)
end
def
closed_issues_url
return
unless
release_mr_issue_urls_available?
project_issues_url
(
project
,
params_for_issues_and_mrs
(
state:
'closed'
))
end
...
...
@@ -89,10 +85,6 @@ class ReleasePresenter < Gitlab::View::Presenter::Delegated
{
scope:
'all'
,
state:
state
,
release_tag:
release
.
tag
}
end
def
release_mr_issue_urls_available?
::
Feature
.
enabled?
(
:release_mr_issue_urls
,
project
,
default_enabled:
true
)
end
def
release_edit_page_available?
can?
(
current_user
,
:update_release
,
release
)
end
...
...
config/feature_flags/development/release_mr_issue_urls.yml
deleted
100644 → 0
View file @
987ce34c
---
name
:
release_mr_issue_urls
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/18727
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/276619
milestone
:
'
12.4'
type
:
development
group
:
group::release
default_enabled
:
true
spec/presenters/release_presenter_spec.rb
View file @
4adabdc0
...
...
@@ -77,14 +77,6 @@ RSpec.describe ReleasePresenter do
it
'returns merge requests url with state=open'
do
is_expected
.
to
eq
(
project_merge_requests_url
(
project
,
opened_url_params
))
end
context
'when release_mr_issue_urls feature flag is disabled'
do
before
do
stub_feature_flags
(
release_mr_issue_urls:
false
)
end
it
{
is_expected
.
to
be_nil
}
end
end
describe
'#merged_merge_requests_url'
do
...
...
@@ -94,13 +86,6 @@ RSpec.describe ReleasePresenter do
is_expected
.
to
eq
(
project_merge_requests_url
(
project
,
merged_url_params
))
end
context
'when release_mr_issue_urls feature flag is disabled'
do
before
do
stub_feature_flags
(
release_mr_issue_urls:
false
)
end
it
{
is_expected
.
to
be_nil
}
end
end
describe
'#closed_merge_requests_url'
do
...
...
@@ -109,14 +94,6 @@ RSpec.describe ReleasePresenter do
it
'returns merge requests url with state=closed'
do
is_expected
.
to
eq
(
project_merge_requests_url
(
project
,
closed_url_params
))
end
context
'when release_mr_issue_urls feature flag is disabled'
do
before
do
stub_feature_flags
(
release_mr_issue_urls:
false
)
end
it
{
is_expected
.
to
be_nil
}
end
end
describe
'#opened_issues_url'
do
...
...
@@ -125,14 +102,6 @@ RSpec.describe ReleasePresenter do
it
'returns issues url with state=open'
do
is_expected
.
to
eq
(
project_issues_url
(
project
,
opened_url_params
))
end
context
'when release_mr_issue_urls feature flag is disabled'
do
before
do
stub_feature_flags
(
release_mr_issue_urls:
false
)
end
it
{
is_expected
.
to
be_nil
}
end
end
describe
'#closed_issues_url'
do
...
...
@@ -141,14 +110,6 @@ RSpec.describe ReleasePresenter do
it
'returns issues url with state=closed'
do
is_expected
.
to
eq
(
project_issues_url
(
project
,
closed_url_params
))
end
context
'when release_mr_issue_urls feature flag is disabled'
do
before
do
stub_feature_flags
(
release_mr_issue_urls:
false
)
end
it
{
is_expected
.
to
be_nil
}
end
end
describe
'#edit_url'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment