Merge branch 'mc/feature/remove-track_all_ci_template_inclusions-ff' into 'master'

Remove track_all_ci_template_inclusions FF

See merge request gitlab-org/gitlab!70380

config/feature_flags/development/track_all_ci_template_inclusions.yml

----
-name: track_all_ci_template_inclusions
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69204
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/339684
-milestone: '14.3'
-type: development
-group: group::pipeline authoring
-default_enabled: false

lib/gitlab/usage_data_counters/ci_template_unique_counter.rb

@@ -21,8 +21,6 @@ module Gitlab::UsageDataCounters
 
     class << self
       def track_unique_project_event(project_id:, template:, config_source:)
-        return unless TEMPLATE_TO_EVENT[template] || Feature.enabled?(:track_all_ci_template_inclusions, default_enabled: :yaml)
-
         Gitlab::UsageDataCounters::HLLRedisCounter.track_event(ci_template_event_name(template, config_source), values: project_id)
       end
 

spec/lib/gitlab/usage_data_counters/ci_template_unique_counter_spec.rb

@@ -90,29 +90,11 @@ RSpec.describe Gitlab::UsageDataCounters::CiTemplateUniqueCounter do
           end.not_to raise_error
         end
 
-        context 'when feature flag is disabled' do
-          before do
-            stub_feature_flags(track_all_ci_template_inclusions: false)
-          end
-
-          it "does not track #{template}" do
-            expect(Gitlab::UsageDataCounters::HLLRedisCounter).not_to(receive(:track_event))
-
-            described_class.track_unique_project_event(project_id: project_id, template: template, config_source: config_source)
-          end
-        end
+        it "tracks #{template}" do
+          expected_template_event_name = described_class.ci_template_event_name(template, :repository_source)
+          expect(Gitlab::UsageDataCounters::HLLRedisCounter).to(receive(:track_event)).with(expected_template_event_name, values: project_id)
 
-        context 'when feature flag is enabled' do
-          before do
-            stub_feature_flags(track_all_ci_template_inclusions: true)
-          end
-
-          it "tracks #{template}" do
-            expected_template_event_name = described_class.ci_template_event_name(template, :repository_source)
-            expect(Gitlab::UsageDataCounters::HLLRedisCounter).to(receive(:track_event)).with(expected_template_event_name, values: project_id)
-
-            described_class.track_unique_project_event(project_id: project_id, template: template, config_source: config_source)
-          end
+          described_class.track_unique_project_event(project_id: project_id, template: template, config_source: config_source)
         end
       end
     end