Merge branch 'rspec-empty-line-after-letitbe-ee-spec-views' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/views

See merge request gitlab-org/gitlab!58280

.rubocop_manual_todo.yml

@@ -643,12 +643,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb
     - ee/spec/support/shared_examples/quick_actions/issue/status_page_quick_actions_shared_examples.rb
     - ee/spec/support/shared_examples/services/search_notes_shared_examples.rb
-    - ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb
-    - ee/spec/views/groups/_compliance_frameworks.html.haml_spec.rb
-    - ee/spec/views/groups/edit.html.haml_spec.rb
-    - ee/spec/views/projects/pipelines/_tabs_content.html.haml_spec.rb
-    - ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb
-    - ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb
     - spec/controllers/confirmations_controller_spec.rb
     - spec/controllers/dashboard/projects_controller_spec.rb
     - spec/controllers/invites_controller_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-views.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/views
+merge_request: 58280
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe 'admin/application_settings/_elasticsearch_form' do
   let_it_be(:admin) { create(:admin) }
+
   let(:page) { Capybara::Node::Simple.new(rendered) }
   let(:pause_indexing) { false }
   let(:pending_migrations) { false }

ee/spec/views/groups/_compliance_frameworks.html.haml_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe 'groups/_compliance_frameworks.html.haml' do
   let_it_be(:group) { build(:group) }
+
   let(:title) { 'Compliance frameworks' }
   let(:description) { 'Configure frameworks to apply enforceable rules to projects.' }
 

ee/spec/views/groups/edit.html.haml_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe 'groups/edit.html.haml' do
   let_it_be(:user) { create(:user) }
+
   let(:group) { create(:group) }
 
   before do

ee/spec/views/projects/pipelines/_tabs_content.html.haml_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe 'projects/pipelines/_tabs_content' do
   let_it_be(:user) { create(:user) }
+
   let(:pipeline) { create(:ci_pipeline).present(current_user: user) }
   let(:locals) { { pipeline: pipeline, project: pipeline.project } }
 

ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe 'shared/billings/_eoa_bronze_plan_banner.html.haml' do
   let_it_be(:user) { create(:user) }
+
   let(:eoa_bronze_plan_end_date) { Date.current + 5.days}
 
   stub_feature_flags(show_billing_eoa_banner: true)

ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe 'shared/billings/_trial_status.html.haml' do
   include ApplicationHelper
 
   let_it_be(:group) { create(:group) }
+
   let(:plan) { nil }
   let(:trial_ends_on) { nil }
   let(:trial) { false }