Merge branch '214382-remove-registrations_recaptcha-feature-flag' into 'master'

Remove registrations_recaptcha feature flag

See merge request gitlab-org/gitlab!31797

app/controllers/registrations_controller.rb

@@ -137,7 +137,6 @@ class RegistrationsController < Devise::RegistrationsController
   def check_captcha
     ensure_correct_params!
 
-    return unless Feature.enabled?(:registrations_recaptcha, default_enabled: true) # reCAPTCHA on the UI will still display however
     return unless show_recaptcha_sign_up?
     return unless Gitlab::Recaptcha.load_configurations!
 

changelogs/unreleased/214382-remove-registrations_recaptcha-feature-flag.yml

+---
+title: Remove registrations_recaptcha feature flag.
+merge_request: 31797
+author: Gilang Gumilar
+type: removed

spec/controllers/registrations_controller_spec.rb

@@ -144,16 +144,6 @@ describe RegistrationsController do
 
         expect(flash[:notice]).to eq(I18n.t('devise.registrations.signed_up'))
       end
-
-      it 'does not require reCAPTCHA if disabled by feature flag' do
-        stub_feature_flags(registrations_recaptcha: false)
-
-        post(:create, params: user_params)
-
-        expect(controller).not_to receive(:verify_recaptcha)
-        expect(flash[:alert]).to be_nil
-        expect(flash[:notice]).to eq(I18n.t('devise.registrations.signed_up'))
-      end
     end
 
     context 'when invisible captcha is enabled' do
@@ -294,8 +284,6 @@ describe RegistrationsController do
     end
 
     it "logs a 'User Created' message" do
-      stub_feature_flags(registrations_recaptcha: false)
-
       expect(Gitlab::AppLogger).to receive(:info).with(/\AUser Created: username=new_username email=new@user.com.+\z/).and_call_original
 
       post(:create, params: user_params)