Commit 4f8869c6 authored by Yogi's avatar Yogi Committed by David O'Regan

Fix alignment and font issues in project operations settings page

parent 546e8436
...@@ -54,9 +54,9 @@ export default { ...@@ -54,9 +54,9 @@ export default {
<template> <template>
<section id="grafana" class="settings no-animate js-grafana-integration"> <section id="grafana" class="settings no-animate js-grafana-integration">
<div class="settings-header"> <div class="settings-header">
<h3 class="js-section-header h4"> <h4 class="js-section-header">
{{ s__('GrafanaIntegration|Grafana authentication') }} {{ s__('GrafanaIntegration|Grafana authentication') }}
</h3> </h4>
<gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button> <gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button>
<p class="js-section-sub-header"> <p class="js-section-sub-header">
{{ s__('GrafanaIntegration|Embed Grafana charts in GitLab issues.') }} {{ s__('GrafanaIntegration|Embed Grafana charts in GitLab issues.') }}
......
...@@ -26,7 +26,7 @@ export default { ...@@ -26,7 +26,7 @@ export default {
class="settings no-animate qa-incident-management-settings" class="settings no-animate qa-incident-management-settings"
> >
<div class="settings-header"> <div class="settings-header">
<h4 ref="sectionHeader" class="gl-my-3! gl-py-1"> <h4 ref="sectionHeader">
{{ $options.i18n.headerText }} {{ $options.i18n.headerText }}
</h4> </h4>
<gl-button ref="toggleBtn" class="js-settings-toggle">{{ <gl-button ref="toggleBtn" class="js-settings-toggle">{{
......
...@@ -31,9 +31,9 @@ export default { ...@@ -31,9 +31,9 @@ export default {
<template> <template>
<section class="settings no-animate"> <section class="settings no-animate">
<div class="settings-header"> <div class="settings-header">
<h3 class="js-section-header h4"> <h4 class="js-section-header">
{{ s__('MetricsSettings|Metrics dashboard') }} {{ s__('MetricsSettings|Metrics dashboard') }}
</h3> </h4>
<gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button> <gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button>
<p class="js-section-sub-header"> <p class="js-section-sub-header">
{{ s__('MetricsSettings|Manage Metrics Dashboard settings.') }} {{ s__('MetricsSettings|Manage Metrics Dashboard settings.') }}
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
%section.settings.no-animate#js-alert-management-settings{ class: ('expanded' if expanded) } %section.settings.no-animate#js-alert-management-settings{ class: ('expanded' if expanded) }
.settings-header .settings-header
%h3{ :class => "h4" } %h4
= _('Alerts') = _('Alerts')
%button.btn.js-settings-toggle{ type: 'button' } %button.btn.js-settings-toggle{ type: 'button' }
= _('Expand') = _('Expand')
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
%section.settings.no-animate.js-error-tracking-settings %section.settings.no-animate.js-error-tracking-settings
.settings-header .settings-header
%h3{ :class => "h4" } %h4
= _('Error tracking') = _('Error tracking')
%button.btn.js-settings-toggle{ type: 'button' } %button.btn.js-settings-toggle{ type: 'button' }
= _('Expand') = _('Expand')
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
%section.settings.border-0.no-animate %section.settings.border-0.no-animate
.settings-header{ :class => "border-top" } .settings-header{ :class => "border-top" }
%h3{ :class => "h4" } %h4
= _("Jaeger tracing") = _("Jaeger tracing")
%button.btn.gl-button.js-settings-toggle{ type: 'button' } %button.btn.gl-button.js-settings-toggle{ type: 'button' }
= _('Expand') = _('Expand')
......
---
title: Fix alignment and font issues in project operations settings page
merge_request: 51825
author: Yogi (@yo)
type: fixed
...@@ -75,7 +75,7 @@ export default { ...@@ -75,7 +75,7 @@ export default {
<template> <template>
<section id="status-page" class="settings no-animate js-status-page-settings"> <section id="status-page" class="settings no-animate js-status-page-settings">
<div class="settings-header"> <div class="settings-header">
<h4 ref="sectionHeader" class="gl-my-3! gl-py-1"> <h4 ref="sectionHeader">
{{ $options.i18n.headerText }} {{ $options.i18n.headerText }}
</h4> </h4>
<gl-button ref="toggleBtn" class="js-settings-toggle">{{ <gl-button ref="toggleBtn" class="js-settings-toggle">{{
......
...@@ -8,9 +8,7 @@ exports[`Status Page settings form default state should match the default snapsh ...@@ -8,9 +8,7 @@ exports[`Status Page settings form default state should match the default snapsh
<div <div
class="settings-header" class="settings-header"
> >
<h4 <h4>
class="gl-my-3! gl-py-1"
>
Status page Status page
......
...@@ -25,7 +25,7 @@ RSpec.describe 'Alert integrations settings form', :js do ...@@ -25,7 +25,7 @@ RSpec.describe 'Alert integrations settings form', :js do
it 'shows the alerts setting form title' do it 'shows the alerts setting form title' do
page.within('#js-alert-management-settings') do page.within('#js-alert-management-settings') do
expect(find('h3')).to have_content('Alerts') expect(find('h4')).to have_content('Alerts')
end end
end end
......
...@@ -8,13 +8,13 @@ exports[`grafana integration component default state to match the default snapsh ...@@ -8,13 +8,13 @@ exports[`grafana integration component default state to match the default snapsh
<div <div
class="settings-header" class="settings-header"
> >
<h3 <h4
class="js-section-header h4" class="js-section-header"
> >
Grafana authentication Grafana authentication
</h3> </h4>
<gl-button-stub <gl-button-stub
buttontextclasses="" buttontextclasses=""
......
...@@ -9,9 +9,7 @@ exports[`IncidentsSettingTabs should render the component 1`] = ` ...@@ -9,9 +9,7 @@ exports[`IncidentsSettingTabs should render the component 1`] = `
<div <div
class="settings-header" class="settings-header"
> >
<h4 <h4>
class="gl-my-3! gl-py-1"
>
Incidents Incidents
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment