Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
50370d88
Commit
50370d88
authored
Jan 24, 2017
by
Sean McGivern
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'document-approvals' into 'master'
Document removing approval See merge request !1086
parents
2a634dc0
3cc72c23
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
1 deletion
+16
-1
doc/user/project/merge_requests/img/remove_approval_mr.png
doc/user/project/merge_requests/img/remove_approval_mr.png
+0
-0
doc/user/project/merge_requests/merge_request_approvals.md
doc/user/project/merge_requests/merge_request_approvals.md
+14
-0
doc/workflow/notifications.md
doc/workflow/notifications.md
+2
-1
No files found.
doc/user/project/merge_requests/img/remove_approval_mr.png
0 → 100644
View file @
50370d88
20.1 KB
doc/user/project/merge_requests/merge_request_approvals.md
View file @
50370d88
...
@@ -68,6 +68,16 @@ assign several users with one action. One possible scenario would be to to assig
...
@@ -68,6 +68,16 @@ assign several users with one action. One possible scenario would be to to assig
a group of approvers at the project level and change them later when creating
a group of approvers at the project level and change them later when creating
or editing the merge request.
or editing the merge request.
## Removing approval
A designated approver can remove their approval at any time. If, when an approver
removes their approval, the number of approvals given falls below the number of
required approvals, the merge request cannot be accepted.
If, on the other hand, an approver removes their approval but the number of approvals
given stays at or above the number of required approvals, the merge request can still be
accepted.
## Using approvals
## Using approvals
After configuring approvals, you will be able to change the default set of
After configuring approvals, you will be able to change the default set of
...
@@ -93,3 +103,7 @@ will be decreased by one.
...
@@ -93,3 +103,7 @@ will be decreased by one.
![
Merge request approval
](
img/approvals_mr_approved.png
)
![
Merge request approval
](
img/approvals_mr_approved.png
)
[
ee-743
]:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/743
[
ee-743
]:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/743
To remove approval, just press the
**Remove your approval**
button
![
Merge request remove approval
](
img/remove_approval_mr.png
)
doc/workflow/notifications.md
View file @
50370d88
...
@@ -88,11 +88,12 @@ In all of the below cases, the notification will be sent to:
...
@@ -88,11 +88,12 @@ In all of the below cases, the notification will be sent to:
| Close merge request | |
| Close merge request | |
| Reopen merge request | |
| Reopen merge request | |
| Merge merge request | |
| Merge merge request | |
| Approved merge request | |
| Unapproved merge request | |
| New comment | The above, plus anyone mentioned by
`@username`
in the comment, with notification level "Mention" or higher |
| New comment | The above, plus anyone mentioned by
`@username`
in the comment, with notification level "Mention" or higher |
| Failed pipeline | The above, plus the author of the pipeline |
| Failed pipeline | The above, plus the author of the pipeline |
| Successful pipeline | The above, plus the author of the pipeline |
| Successful pipeline | The above, plus the author of the pipeline |
In addition, if the title or description of an Issue or Merge Request is
In addition, if the title or description of an Issue or Merge Request is
changed, notifications will be sent to any
**new**
mentions by
`@username`
as
changed, notifications will be sent to any
**new**
mentions by
`@username`
as
if they had been mentioned in the original text.
if they had been mentioned in the original text.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment