Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5049097d
Commit
5049097d
authored
Jun 02, 2021
by
Pedro Pombeiro
Committed by
Adam Hegyi
Jun 14, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Ci::RunnersFinder.ALLOWED_SORTS
parent
cd7b81bd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
app/finders/ci/runners_finder.rb
app/finders/ci/runners_finder.rb
+2
-2
spec/finders/ci/runners_finder_spec.rb
spec/finders/ci/runners_finder_spec.rb
+2
-2
No files found.
app/finders/ci/runners_finder.rb
View file @
5049097d
...
@@ -4,8 +4,8 @@ module Ci
...
@@ -4,8 +4,8 @@ module Ci
class
RunnersFinder
<
UnionFinder
class
RunnersFinder
<
UnionFinder
include
Gitlab
::
Allowable
include
Gitlab
::
Allowable
ALLOWED_SORTS
=
%w[contacted_asc contacted_desc created_at_asc created_at_desc]
.
freeze
ALLOWED_SORTS
=
%w[contacted_asc contacted_desc created_at_asc created_at_desc
created_date
]
.
freeze
DEFAULT_SORT
=
'created_
date
'
DEFAULT_SORT
=
'created_
at_desc
'
def
initialize
(
current_user
:,
group:
nil
,
params
:)
def
initialize
(
current_user
:,
group:
nil
,
params
:)
@params
=
params
@params
=
params
...
...
spec/finders/ci/runners_finder_spec.rb
View file @
5049097d
...
@@ -278,8 +278,8 @@ RSpec.describe Ci::RunnersFinder do
...
@@ -278,8 +278,8 @@ RSpec.describe Ci::RunnersFinder do
subject
{
described_class
.
new
(
current_user:
user
,
group:
group
,
params:
params
).
sort_key
}
subject
{
described_class
.
new
(
current_user:
user
,
group:
group
,
params:
params
).
sort_key
}
context
'no params'
do
context
'no params'
do
it
'returns created_
date
'
do
it
'returns created_
at_desc
'
do
expect
(
subject
).
to
eq
(
'created_
date
'
)
expect
(
subject
).
to
eq
(
'created_
at_desc
'
)
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment