Merge branch 'issue#325836-fix-empty-line-after-let-it-be-design-management-module' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses for design management module

See merge request gitlab-org/gitlab!58189

.rubocop_manual_todo.yml

@@ -685,8 +685,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/finders/ci/commit_statuses_finder_spec.rb
     - spec/finders/container_repositories_finder_spec.rb
     - spec/finders/deployments_finder_spec.rb
-    - spec/finders/design_management/designs_finder_spec.rb
-    - spec/finders/design_management/versions_finder_spec.rb
     - spec/finders/events_finder_spec.rb
     - spec/finders/group_descendants_finder_spec.rb
     - spec/finders/groups_finder_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-design-management-module.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses for design management module
+merge_request: 58189
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/finders/design_management/designs_finder_spec.rb

@@ -11,6 +11,7 @@ RSpec.describe DesignManagement::DesignsFinder do
   let_it_be(:design1) { create(:design, :with_file, issue: issue, versions_count: 1, relative_position: 3) }
   let_it_be(:design2) { create(:design, :with_file, issue: issue, versions_count: 1, relative_position: 2) }
   let_it_be(:design3) { create(:design, :with_file, issue: issue, versions_count: 1, relative_position: 1) }
+
   let(:params) { {} }
 
   subject(:designs) { described_class.new(issue, user, params).execute }

spec/finders/design_management/versions_finder_spec.rb

@@ -10,6 +10,7 @@ RSpec.describe DesignManagement::VersionsFinder do
   let_it_be(:issue) { create(:issue, project: project) }
   let_it_be(:design_1) { create(:design, :with_file, issue: issue, versions_count: 1) }
   let_it_be(:design_2) { create(:design, :with_file, issue: issue, versions_count: 1) }
+
   let(:version_1) { design_1.versions.first }
   let(:version_2) { design_2.versions.first }
   let(:design_or_collection) { issue.design_collection }