Return early if there were no references in text

5137fce2 · Bob Van Landuyt · 118d1240 · 5137fce2
Commit 5137fce2 authored Mar 13, 2019 by Bob Van Landuyt
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

lib/gitlab/user_extractor.rb lib/gitlab/user_extractor.rb +2 -5

No files found.
--- a/lib/gitlab/user_extractor.rb
+++ b/lib/gitlab/user_extractor.rb
@@ -16,12 +16,9 @@ module Gitlab

    def users
      return User.none unless @text.present?
+      return User.none if references.empty?

-      relations = union_relations
-
-      return User.none unless relations.any?
-
-      @users ||= User.from_union(relations)
+      @users ||= User.from_union(union_relations)
    end

    def usernames