Commit 524514f3 authored by Rémy Coutable's avatar Rémy Coutable

Auto-correct Cop/LineBreakAroundConditionalBlock violations from rebase

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent 6a480da9
...@@ -62,6 +62,7 @@ module KerberosSpnegoHelper ...@@ -62,6 +62,7 @@ module KerberosSpnegoHelper
else else
nil # accept any valid service principal name from keytab nil # accept any valid service principal name from keytab
end end
gss.acquire_credentials(gss_service_name) # grab credentials from keytab gss.acquire_credentials(gss_service_name) # grab credentials from keytab
# Decode token # Decode token
......
...@@ -86,6 +86,7 @@ module MergeRequestsHelper ...@@ -86,6 +86,7 @@ module MergeRequestsHelper
approvers_names = merge_request.approvers_left.map(&:name) approvers_names = merge_request.approvers_left.map(&:name)
str << str <<
if more_approvals > 0 if more_approvals > 0
" (from #{render_items_list(approvers_names + ["#{more_approvals} more"])})" " (from #{render_items_list(approvers_names + ["#{more_approvals} more"])})"
elsif more_approvals < 0 elsif more_approvals < 0
......
...@@ -163,6 +163,7 @@ module MilestonesHelper ...@@ -163,6 +163,7 @@ module MilestonesHelper
def show_burndown_placeholder?(warning) def show_burndown_placeholder?(warning)
return false if cookies['hide_burndown_message'].present? return false if cookies['hide_burndown_message'].present?
return false unless @project.feature_available?(:burndown_charts, current_user) && return false unless @project.feature_available?(:burndown_charts, current_user) &&
@project.feature_available?(:issue_weights, current_user) @project.feature_available?(:issue_weights, current_user)
......
...@@ -4,6 +4,7 @@ module EE ...@@ -4,6 +4,7 @@ module EE
module GroupsController module GroupsController
def reset_runners_minutes def reset_runners_minutes
group group
if ClearNamespaceSharedRunnersMinutesService.new(@group).execute if ClearNamespaceSharedRunnersMinutesService.new(@group).execute
redirect_to [:admin, @group], notice: 'Group pipeline minutes were successfully reset.' redirect_to [:admin, @group], notice: 'Group pipeline minutes were successfully reset.'
else else
......
...@@ -4,6 +4,7 @@ module EE ...@@ -4,6 +4,7 @@ module EE
module UsersController module UsersController
def reset_runners_minutes def reset_runners_minutes
user user
if ClearNamespaceSharedRunnersMinutesService.new(@user.namespace).execute if ClearNamespaceSharedRunnersMinutesService.new(@user.namespace).execute
redirect_to [:admin, @user], notice: 'User pipeline minutes were successfully reset.' redirect_to [:admin, @user], notice: 'User pipeline minutes were successfully reset.'
else else
......
...@@ -18,6 +18,7 @@ class Projects::PushRulesController < Projects::ApplicationController ...@@ -18,6 +18,7 @@ class Projects::PushRulesController < Projects::ApplicationController
else else
flash[:alert] = @push_rule.errors.full_messages.join(', ').html_safe flash[:alert] = @push_rule.errors.full_messages.join(', ').html_safe
end end
redirect_to_repository_settings(@project) redirect_to_repository_settings(@project)
end end
......
...@@ -13,6 +13,7 @@ class UnsubscribesController < ApplicationController ...@@ -13,6 +13,7 @@ class UnsubscribesController < ApplicationController
@user.admin_unsubscribe! @user.admin_unsubscribe!
Notify.send_unsubscribed_notification(@user.id).deliver_later Notify.send_unsubscribed_notification(@user.id).deliver_later
end end
redirect_to new_user_session_path, notice: 'You have been unsubscribed' redirect_to new_user_session_path, notice: 'You have been unsubscribed'
end end
......
...@@ -30,6 +30,7 @@ module LicenseHelper ...@@ -30,6 +30,7 @@ module LicenseHelper
message << block_changes_message message << block_changes_message
message << message <<
if is_admin if is_admin
'Upload a new license in the admin area' 'Upload a new license in the admin area'
else else
......
...@@ -21,11 +21,13 @@ class LdapGroupSyncWorker ...@@ -21,11 +21,13 @@ class LdapGroupSyncWorker
def sync_group(group, proxy: nil) def sync_group(group, proxy: nil)
logger.info "Started LDAP group sync for group #{group.name} (#{group.id})" logger.info "Started LDAP group sync for group #{group.name} (#{group.id})"
if proxy if proxy
EE::Gitlab::LDAP::Sync::Group.execute(group, proxy) EE::Gitlab::LDAP::Sync::Group.execute(group, proxy)
else else
EE::Gitlab::LDAP::Sync::Group.execute_all_providers(group) EE::Gitlab::LDAP::Sync::Group.execute_all_providers(group)
end end
logger.info "Finished LDAP group sync for group #{group.name} (#{group.id})" logger.info "Finished LDAP group sync for group #{group.name} (#{group.id})"
end end
end end
...@@ -10,6 +10,7 @@ module SystemCheck ...@@ -10,6 +10,7 @@ module SystemCheck
def multi_check def multi_check
$stdout.puts $stdout.puts
if Gitlab::Geo.primary? if Gitlab::Geo.primary?
Gitlab::Geo.secondary_nodes.each do |node| Gitlab::Geo.secondary_nodes.each do |node|
$stdout.print "* Can connect to secondary node: '#{node.url}' ... " $stdout.print "* Can connect to secondary node: '#{node.url}' ... "
......
...@@ -256,6 +256,7 @@ module API ...@@ -256,6 +256,7 @@ module API
if group.pending_ldap_sync if group.pending_ldap_sync
LdapGroupSyncWorker.perform_async(group.id) LdapGroupSyncWorker.perform_async(group.id)
end end
status 202 status 202
end end
end end
......
...@@ -72,6 +72,7 @@ namespace :geo do ...@@ -72,6 +72,7 @@ namespace :geo do
if Gitlab::Geo::DatabaseTasks.dump_schema_after_migration? if Gitlab::Geo::DatabaseTasks.dump_schema_after_migration?
ns["schema:dump"].invoke ns["schema:dump"].invoke
end end
# Allow this task to be called as many times as required. An example is the # Allow this task to be called as many times as required. An example is the
# migrate:redo task, which calls other two internally that depend on this one. # migrate:redo task, which calls other two internally that depend on this one.
ns['_dump'].reenable ns['_dump'].reenable
......
...@@ -57,6 +57,7 @@ namespace :gitlab do ...@@ -57,6 +57,7 @@ namespace :gitlab do
IO.popen(%W(find #{repo_root} -mindepth 1 -maxdepth 2 -name *+moved*.git)) do |find| IO.popen(%W(find #{repo_root} -mindepth 1 -maxdepth 2 -name *+moved*.git)) do |find|
find.each_line do |path| find.each_line do |path|
path.chomp! path.chomp!
if remove_flag if remove_flag
if FileUtils.rm_rf(path) if FileUtils.rm_rf(path)
puts "Removed...#{path}".color(:green) puts "Removed...#{path}".color(:green)
......
...@@ -126,6 +126,7 @@ namespace :gitlab do ...@@ -126,6 +126,7 @@ namespace :gitlab do
puts 'Index mapping is already up to date'.color(:yellow) puts 'Index mapping is already up to date'.color(:yellow)
exit exit
end end
#### ####
project_fields = { project_fields = {
......
...@@ -507,6 +507,7 @@ describe 'Scoped issue boards', :js do ...@@ -507,6 +507,7 @@ describe 'Scoped issue boards', :js do
page.within(".#{filter}") do page.within(".#{filter}") do
click_button 'Edit' click_button 'Edit'
if value.is_a?(Array) if value.is_a?(Array)
value.each { |value| click_link value } value.each { |value| click_link value }
else else
......
...@@ -60,15 +60,19 @@ FactoryBot.define do ...@@ -60,15 +60,19 @@ FactoryBot.define do
if user = evaluator.authorize_user_to_push if user = evaluator.authorize_user_to_push
protected_branch.push_access_levels.new(user: user) protected_branch.push_access_levels.new(user: user)
end end
if user = evaluator.authorize_user_to_merge if user = evaluator.authorize_user_to_merge
protected_branch.merge_access_levels.new(user: user) protected_branch.merge_access_levels.new(user: user)
end end
if group = evaluator.authorize_group_to_push if group = evaluator.authorize_group_to_push
protected_branch.push_access_levels.new(group: group) protected_branch.push_access_levels.new(group: group)
end end
if group = evaluator.authorize_group_to_merge if group = evaluator.authorize_group_to_merge
protected_branch.merge_access_levels.new(group: group) protected_branch.merge_access_levels.new(group: group)
end end
next unless protected_branch.merge_access_levels.empty? next unless protected_branch.merge_access_levels.empty?
if evaluator.default_access_level && evaluator.default_push_level if evaluator.default_access_level && evaluator.default_push_level
......
...@@ -46,6 +46,7 @@ FactoryBot.define do ...@@ -46,6 +46,7 @@ FactoryBot.define do
if evaluator.authorize_user_to_create if evaluator.authorize_user_to_create
protected_tag.create_access_levels.new(user: evaluator.authorize_user_to_create) protected_tag.create_access_levels.new(user: evaluator.authorize_user_to_create)
end end
if evaluator.authorize_group_to_create if evaluator.authorize_group_to_create
protected_tag.create_access_levels.new(group: evaluator.authorize_group_to_create) protected_tag.create_access_levels.new(group: evaluator.authorize_group_to_create)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment