Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
52dc5f1d
Commit
52dc5f1d
authored
Jul 22, 2020
by
Uday Aggarwal
Committed by
Kushal Pandya
Jul 22, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
changed the default value of checkbox to false from a dynamic value on first page load
parent
2bbc4d78
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
0 deletions
+14
-0
ee/app/assets/javascripts/security_dashboard/components/vulnerability_list.vue
...ipts/security_dashboard/components/vulnerability_list.vue
+3
-0
ee/changelogs/unreleased/Fix_Dimiss_Checkbox_Security_Dashboard.yml
...ogs/unreleased/Fix_Dimiss_Checkbox_Security_Dashboard.yml
+6
-0
ee/spec/frontend/security_dashboard/components/vulnerability_list_spec.js
.../security_dashboard/components/vulnerability_list_spec.js
+5
-0
No files found.
ee/app/assets/javascripts/security_dashboard/components/vulnerability_list.vue
View file @
52dc5f1d
...
...
@@ -103,6 +103,9 @@ export default {
return
Object
.
keys
(
this
.
filters
).
length
>
0
;
},
hasSelectedAllVulnerabilities
()
{
if
(
!
this
.
vulnerabilities
.
length
)
{
return
false
;
}
return
this
.
numOfSelectedVulnerabilities
===
this
.
vulnerabilities
.
length
;
},
numOfSelectedVulnerabilities
()
{
...
...
ee/changelogs/unreleased/Fix_Dimiss_Checkbox_Security_Dashboard.yml
0 → 100644
View file @
52dc5f1d
---
title
:
changed the default value of checkbox to
false
from a dynamic value on first
page load
merge_request
:
36646
author
:
Uday Aggarwal @uday.agg97
type
:
fixed
ee/spec/frontend/security_dashboard/components/vulnerability_list_spec.js
View file @
52dc5f1d
...
...
@@ -318,6 +318,11 @@ describe('Vulnerability list component', () => {
expect
(
findDashboardHasNoVulnerabilities
().
exists
()).
toEqual
(
true
);
expect
(
findFiltersProducedNoResults
().
exists
()).
toEqual
(
false
);
});
it
(
'
should not show the vulnerability check-all checkbox as checked with no vulnerabilities
'
,
()
=>
{
expect
(
findDataCell
(
'
vulnerability-checkbox-all
'
).
exists
()).
toBe
(
true
);
expect
(
findDataCell
(
'
vulnerability-checkbox-all
'
).
element
.
checked
).
toBe
(
false
);
});
});
describe
(
'
with no vulnerabilities when there are filters
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment