Do not keep rootEl dataset in memory.

535fd145 · Bryce Johnson · 02956aab · 535fd145 · 535fd145
Commit 535fd145 authored Dec 20, 2016 by Bryce Johnson
2 changed files
--- a/app/assets/javascripts/merge_request_widget/approvals/approvals_store.js.es6
+++ b/app/assets/javascripts/merge_request_widget/approvals/approvals_store.js.es6
@@ -15,7 +15,7 @@

    init(rootStore) {
      this.rootStore = rootStore;
-      this.api = new gl.ApprovalsApi(rootStore.dataset.endpoint);
+      this.api = new gl.ApprovalsApi(rootStore.rootEl.dataset.endpoint);
      this.state = {
        fetching: false,
      };

--- a/app/assets/javascripts/merge_request_widget/widget_store.js.es6
+++ b/app/assets/javascripts/merge_request_widget/widget_store.js.es6
@@ -14,7 +14,6 @@

    init(rootEl) {
      this.rootEl = rootEl;
-      this.dataset = rootEl.dataset;
      this.data = {};

      // init other widget stores here