Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-checks' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/checks

See merge request gitlab-org/gitlab!58248

.rubocop_manual_todo.yml

@@ -801,8 +801,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb
     - spec/lib/gitlab/auth_spec.rb
     - spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb
-    - spec/lib/gitlab/checks/project_created_spec.rb
-    - spec/lib/gitlab/checks/project_moved_spec.rb
     - spec/lib/gitlab/ci/build/policy/changes_spec.rb
     - spec/lib/gitlab/ci/config/external/file/local_spec.rb
     - spec/lib/gitlab/ci/config/external/file/project_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-checks.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/checks
+merge_request: 58248
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/checks/project_created_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::Checks::ProjectCreated, :clean_gitlab_redis_shared_state do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, :repository, namespace: user.namespace) }
+
   let(:protocol) { 'http' }
   let(:git_user) { user }
   let(:repository) { project.repository }

spec/lib/gitlab/checks/project_moved_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::Checks::ProjectMoved, :clean_gitlab_redis_shared_state do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, :repository, :wiki_repo, namespace: user.namespace) }
+
   let(:repository) { project.repository }
   let(:protocol) { 'http' }
   let(:git_user) { user }
@@ -101,6 +102,7 @@ RSpec.describe Gitlab::Checks::ProjectMoved, :clean_gitlab_redis_shared_state do
 
     context 'with project snippet' do
       let_it_be(:snippet) { create(:project_snippet, :repository, project: project, author: user) }
+
       let(:repository) { snippet.repository }
 
       it_behaves_like 'errors per protocol' do
@@ -111,6 +113,7 @@ RSpec.describe Gitlab::Checks::ProjectMoved, :clean_gitlab_redis_shared_state do
 
     context 'with personal snippet' do
       let_it_be(:snippet) { create(:personal_snippet, :repository, author: user) }
+
       let(:repository) { snippet.repository }
 
       it 'returns nil' do