Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
53e70157
Commit
53e70157
authored
Jun 05, 2019
by
Małgorzata Ksionek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add condition to policies
Alongside specs
parent
d283e36d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
0 deletions
+26
-0
ee/app/policies/ee/project_policy.rb
ee/app/policies/ee/project_policy.rb
+7
-0
ee/spec/policies/project_policy_spec.rb
ee/spec/policies/project_policy_spec.rb
+19
-0
No files found.
ee/app/policies/ee/project_policy.rb
View file @
53e70157
...
...
@@ -210,6 +210,8 @@ module EE
rule
{
owner
|
reporter
}.
enable
:build_read_project
rule
{
owner
&
owner_cannot_destroy_project
}.
prevent
:remove_project
rule
{
archived
}.
policy
do
READONLY_FEATURES_WHEN_ARCHIVED
.
each
do
|
feature
|
prevent
(
*::
ProjectPolicy
.
create_update_admin_destroy
(
feature
))
...
...
@@ -228,6 +230,11 @@ module EE
::
Gitlab
::
Auth
::
GroupSaml
::
SsoEnforcer
.
group_access_restricted?
(
subject
.
group
)
end
condition
(
:owner_cannot_destroy_project
)
do
::
Gitlab
::
CurrentSettings
.
current_application_settings
.
default_project_deletion_protection
end
rule
{
web_ide_terminal_available
&
can?
(
:create_pipeline
)
&
can?
(
:maintainer_access
)
}.
enable
:create_web_ide_terminal
# Design abilities could also be prevented in the issue policy.
...
...
ee/spec/policies/project_policy_spec.rb
View file @
53e70157
...
...
@@ -451,6 +451,25 @@ describe ProjectPolicy do
end
end
describe
'remove_project when default_project_deletion_protection is set to true'
do
before
do
allow
(
Gitlab
::
CurrentSettings
.
current_application_settings
)
.
to
receive
(
:default_project_deletion_protection
)
{
true
}
end
context
'with admin'
do
let
(
:current_user
)
{
admin
}
it
{
is_expected
.
to
be_allowed
(
:remove_project
)
}
end
context
'with owner'
do
let
(
:current_user
)
{
owner
}
it
{
is_expected
.
to
be_disallowed
(
:remove_project
)
}
end
end
describe
'read_feature_flag'
do
context
'with admin'
do
let
(
:current_user
)
{
admin
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment