Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-auth' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/auth

See merge request gitlab-org/gitlab!58246

.rubocop_manual_todo.yml

@@ -750,10 +750,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
     - spec/lib/extracts_path_spec.rb
     - spec/lib/extracts_ref_spec.rb
-    - spec/lib/gitlab/auth/otp/strategies/devise_spec.rb
-    - spec/lib/gitlab/auth/otp/strategies/forti_authenticator_spec.rb
-    - spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb
-    - spec/lib/gitlab/auth_spec.rb
     - spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb
     - spec/lib/gitlab/ci/build/policy/changes_spec.rb
     - spec/lib/gitlab/ci/config/external/file/local_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-auth.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/auth
+merge_request: 58246
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/auth/otp/strategies/devise_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Auth::Otp::Strategies::Devise do
   let_it_be(:user) { create(:user) }
+
   let(:otp_code) { 42 }
 
   subject(:validate) { described_class.new(user).validate(otp_code) }

spec/lib/gitlab/auth/otp/strategies/forti_authenticator_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Auth::Otp::Strategies::FortiAuthenticator do
   let_it_be(:user) { create(:user) }
+
   let(:otp_code) { 42 }
 
   let(:host) { 'forti_authenticator.example.com' }

spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Auth::Otp::Strategies::FortiTokenCloud do
   let_it_be(:user) { create(:user) }
+
   let(:otp_code) { 42 }
 
   let(:url) { 'https://ftc.example.com:9696/api/v1' }

spec/lib/gitlab/auth_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Auth, :use_clean_rails_memory_store_caching do
   let_it_be(:project) { create(:project) }
+
   let(:gl_auth) { described_class }
 
   describe 'constants' do
@@ -543,6 +544,7 @@ RSpec.describe Gitlab::Auth, :use_clean_rails_memory_store_caching do
 
         context 'and belong to different projects' do
           let_it_be(:other_project) { create(:project) }
+
           let!(:read_registry) { create(:deploy_token, username: 'deployer', read_repository: false, projects: [project]) }
           let!(:read_repository) { create(:deploy_token, username: read_registry.username, read_registry: false, projects: [other_project]) }
           let(:auth_success) { Gitlab::Auth::Result.new(read_repository, other_project, :deploy_token, [:download_code]) }