Commit 540c453b authored by Heinrich Lee Yu's avatar Heinrich Lee Yu

Merge branch 'remove-ci_bulk_insert_on_create' into 'master'

Remove `ci_bulk_insert_on_create` feature flag

See merge request gitlab-org/gitlab!43548
parents 1f21a463 8b337e15
......@@ -58,7 +58,7 @@ module Ci
build = project.builds.new(attributes)
build.assign_attributes(::Gitlab::Ci::Pipeline::Seed::Build.environment_attributes_for(build))
build.retried = false
BulkInsertableAssociations.with_bulk_insert(enabled: ::Gitlab::Ci::Features.bulk_insert_on_create?(project)) do
BulkInsertableAssociations.with_bulk_insert do
build.save!
end
build
......
---
name: ci_bulk_insert_on_create
introduced_by_url:
rollout_issue_url:
group:
type: development
default_enabled: true
......@@ -31,10 +31,6 @@ module Gitlab
::Feature.enabled?(:ci_raise_job_rules_without_workflow_rules_warning, default_enabled: true)
end
def self.bulk_insert_on_create?(project)
::Feature.enabled?(:ci_bulk_insert_on_create, project, default_enabled: true)
end
# NOTE: The feature flag `disallow_to_create_merge_request_pipelines_in_target_project`
# is a safe switch to disable the feature for a parituclar project when something went wrong,
# therefore it's not supposed to be enabled by default.
......
......@@ -8,7 +8,7 @@ module Gitlab
include Chain::Helpers
def perform!
BulkInsertableAssociations.with_bulk_insert(enabled: ::Gitlab::Ci::Features.bulk_insert_on_create?(project)) do
BulkInsertableAssociations.with_bulk_insert do
pipeline.save!
end
rescue ActiveRecord::RecordInvalid => e
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment