Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
541f3463
Commit
541f3463
authored
Jan 13, 2021
by
Samantha Ming
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove redundant let in reviewers spec
Issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/296998
parent
f08ef7b4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
12 deletions
+11
-12
ee/spec/features/merge_request/user_edits_multiple_reviewers_mr_spec.rb
...es/merge_request/user_edits_multiple_reviewers_mr_spec.rb
+11
-12
No files found.
ee/spec/features/merge_request/user_edits_multiple_reviewers_mr_spec.rb
View file @
541f3463
...
@@ -32,22 +32,21 @@ RSpec.describe 'Merge request > User edits MR with multiple reviewers' do
...
@@ -32,22 +32,21 @@ RSpec.describe 'Merge request > User edits MR with multiple reviewers' do
expect
(
page
).
to
have_content
(
rule_name
)
expect
(
page
).
to
have_content
(
rule_name
)
end
end
end
end
end
context
'when reviewer_approval_rules feature flag off'
do
context
'when reviewer_approval_rules feature flag off'
do
let
(
:rule_name
)
{
'some-custom-rule'
}
before
do
let!
(
:mr_rule
)
{
create
(
:approval_merge_request_rule
,
merge_request:
merge_request
,
users:
[
user
],
name:
rule_name
,
approvals_required:
1
)}
stub_feature_flags
(
reviewer_approval_rules:
false
)
before
do
visit
edit_project_merge_request_path
(
target_project
,
merge_request
)
stub_feature_flags
(
reviewer_approval_rules:
false
)
end
end
it
'is not shown in reviewer dropdown'
do
it
'is not shown in reviewer dropdown'
do
find
(
'.js-reviewer-search'
).
click
find
(
'.js-reviewer-search'
).
click
wait_for_requests
wait_for_requests
page
.
within
'.dropdown-menu-reviewer'
do
page
.
within
'.dropdown-menu-reviewer'
do
expect
(
page
).
not_to
have_content
(
rule_name
)
expect
(
page
).
not_to
have_content
(
rule_name
)
end
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment