Commit 541f3463 authored by Samantha Ming's avatar Samantha Ming

Remove redundant let in reviewers spec

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/296998
parent f08ef7b4
...@@ -32,14 +32,12 @@ RSpec.describe 'Merge request > User edits MR with multiple reviewers' do ...@@ -32,14 +32,12 @@ RSpec.describe 'Merge request > User edits MR with multiple reviewers' do
expect(page).to have_content(rule_name) expect(page).to have_content(rule_name)
end end
end end
end
context 'when reviewer_approval_rules feature flag off' do context 'when reviewer_approval_rules feature flag off' do
let(:rule_name) { 'some-custom-rule' }
let!(:mr_rule) { create(:approval_merge_request_rule, merge_request: merge_request, users: [user], name: rule_name, approvals_required: 1 )}
before do before do
stub_feature_flags(reviewer_approval_rules: false) stub_feature_flags(reviewer_approval_rules: false)
visit edit_project_merge_request_path(target_project, merge_request)
end end
it 'is not shown in reviewer dropdown' do it 'is not shown in reviewer dropdown' do
...@@ -51,6 +49,7 @@ RSpec.describe 'Merge request > User edits MR with multiple reviewers' do ...@@ -51,6 +49,7 @@ RSpec.describe 'Merge request > User edits MR with multiple reviewers' do
end end
end end
end end
end
context 'code owner approval rules', :js do context 'code owner approval rules', :js do
let(:code_owner_pattern) { '*' } let(:code_owner_pattern) { '*' }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment