Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
55c5417e
Commit
55c5417e
authored
Dec 04, 2021
by
Kev
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix GraphQL/OrderedArguments offense (Part 3/6)
Changelog: other
parent
87fe2564
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
9 additions
and
12 deletions
+9
-12
.rubocop_todo/graphql/ordered_arguments.yml
.rubocop_todo/graphql/ordered_arguments.yml
+0
-3
app/graphql/resolvers/design_management/version/designs_at_version_resolver.rb
.../design_management/version/designs_at_version_resolver.rb
+3
-3
app/graphql/resolvers/design_management/version_in_collection_resolver.rb
...lvers/design_management/version_in_collection_resolver.rb
+3
-3
app/graphql/resolvers/group_milestones_resolver.rb
app/graphql/resolvers/group_milestones_resolver.rb
+3
-3
No files found.
.rubocop_todo/graphql/ordered_arguments.yml
View file @
55c5417e
...
...
@@ -4,9 +4,6 @@ GraphQL/OrderedArguments:
-
app/graphql/resolvers/base_issues_resolver.rb
-
app/graphql/resolvers/design_management/designs_resolver.rb
-
app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
-
app/graphql/resolvers/design_management/version/designs_at_version_resolver.rb
-
app/graphql/resolvers/design_management/version_in_collection_resolver.rb
-
app/graphql/resolvers/group_milestones_resolver.rb
-
app/graphql/resolvers/merge_requests_resolver.rb
-
app/graphql/resolvers/paginated_tree_resolver.rb
-
app/graphql/resolvers/tree_resolver.rb
...
...
app/graphql/resolvers/design_management/version/designs_at_version_resolver.rb
View file @
55c5417e
...
...
@@ -13,13 +13,13 @@ module Resolvers
DesignID
=
::
Types
::
GlobalIDType
[
::
DesignManagement
::
Design
]
argument
:ids
,
[
DesignID
],
required:
false
,
description:
'Filters designs by their ID.'
argument
:filenames
,
[
GraphQL
::
Types
::
String
],
required:
false
,
description:
'Filters designs by their filename.'
argument
:ids
,
[
DesignID
],
required:
false
,
description:
'Filters designs by their ID.'
def
self
.
single
::
Resolvers
::
DesignManagement
::
Version
::
DesignAtVersionResolver
...
...
app/graphql/resolvers/design_management/version_in_collection_resolver.rb
View file @
55c5417e
...
...
@@ -15,13 +15,13 @@ module Resolvers
VersionID
=
::
Types
::
GlobalIDType
[
::
DesignManagement
::
Version
]
argument
:sha
,
GraphQL
::
Types
::
String
,
required:
false
,
description:
"SHA256 of a specific version."
argument
:id
,
VersionID
,
as: :version_id
,
required:
false
,
description:
'Global ID of the version.'
argument
:sha
,
GraphQL
::
Types
::
String
,
required:
false
,
description:
"SHA256 of a specific version."
def
resolve
(
version_id:
nil
,
sha:
nil
)
# TODO: remove this line when the compatibility layer is removed
...
...
app/graphql/resolvers/group_milestones_resolver.rb
View file @
55c5417e
...
...
@@ -2,12 +2,12 @@
module
Resolvers
class
GroupMilestonesResolver
<
MilestonesResolver
argument
:include_descendants
,
GraphQL
::
Types
::
Boolean
,
required:
false
,
description:
'Include milestones from all subgroups and subprojects.'
argument
:include_ancestors
,
GraphQL
::
Types
::
Boolean
,
required:
false
,
description:
'Include milestones from all parent groups.'
argument
:include_descendants
,
GraphQL
::
Types
::
Boolean
,
required:
false
,
description:
'Include milestones from all subgroups and subprojects.'
type
Types
::
MilestoneType
.
connection_type
,
null:
true
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment