Merge branch 'add-blocks-unsafe-serialization-to-namespace' into 'master'

Add BlocksUnsafeSerialization to Namespace

See merge request gitlab-org/gitlab!82661

app/models/namespace.rb

@@ -15,6 +15,7 @@ class Namespace < ApplicationRecord
   include Namespaces::Traversal::Recursive
   include Namespaces::Traversal::Linear
   include EachBatch
+  include BlocksUnsafeSerialization
 
   # Temporary column used for back-filling project namespaces.
   # Remove it once the back-filling of all project namespaces is done.
@@ -660,6 +661,10 @@ class Namespace < ApplicationRecord
     # Use SHA2 of `traversal_ids` to account for moving a namespace within the same root ancestor hierarchy.
     "namespaces:{#{traversal_ids.first}}:first_auto_devops_config:#{group_id}:#{Digest::SHA2.hexdigest(traversal_ids.join(' '))}"
   end
+
+  def allow_serialization?(options = nil)
+    Feature.disabled?(:block_namespace_serialization, self, default_enabled: :yaml) || super
+  end
 end
 
 Namespace.prepend_mod_with('Namespace')

config/feature_flags/development/block_namespace_serialization.yml

+---
+name: block_namespace_serialization
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82661
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/355553
+milestone: '14.9'
+type: development
+group: group::global search
+default_enabled: false

lib/gitlab/import_export/fast_hash_serializer.rb

@@ -92,7 +92,7 @@ module Gitlab
 
       def simple_serialize
         subject.as_json(
-          tree.merge(include: nil, preloads: nil))
+          tree.merge(include: nil, preloads: nil, unsafe: true))
       end
 
       def serialize_includes

lib/gitlab/import_export/json/streaming_serializer.rb

@@ -37,7 +37,7 @@ module Gitlab
 
         def serialize_root(exportable_path = @exportable_path)
           attributes = exportable.as_json(
-            relations_schema.merge(include: nil, preloads: nil))
+            relations_schema.merge(include: nil, preloads: nil, unsafe: true))
 
           json_writer.write_attributes(exportable_path, attributes)
         end

spec/models/namespace_spec.rb

@@ -2230,4 +2230,18 @@ RSpec.describe Namespace do
       expect(namespace.storage_enforcement_date).to be(nil)
     end
   end
+
+  describe 'serialization' do
+    let(:object) { build(:namespace) }
+
+    it_behaves_like 'blocks unsafe serialization'
+
+    context 'when feature flag block_namespace_serialization is disabled' do
+      before do
+        stub_feature_flags(block_namespace_serialization: false)
+      end
+
+      it_behaves_like 'allows unsafe serialization'
+    end
+  end
 end