Commit 56fd1690 authored by Vitali Tatarintev's avatar Vitali Tatarintev

Merge branch '276901-remove-ci_lint_creates_pipeline_with_dry_run' into 'master'

Remove ci_lint_creates_pipeline_with_dry_run flag

See merge request gitlab-org/gitlab!47426
parents ed6de53e 818d798b
---
name: ci_lint_creates_pipeline_with_dry_run
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37828
rollout_issue_url:
milestone: '13.3'
type: development
group: group::continuous integration
default_enabled: true
...@@ -38,10 +38,6 @@ module Gitlab ...@@ -38,10 +38,6 @@ module Gitlab
::Feature.enabled?(:ci_disallow_to_create_merge_request_pipelines_in_target_project, target_project) ::Feature.enabled?(:ci_disallow_to_create_merge_request_pipelines_in_target_project, target_project)
end end
def self.lint_creates_pipeline_with_dry_run?(project)
::Feature.enabled?(:ci_lint_creates_pipeline_with_dry_run, project, default_enabled: true)
end
def self.project_transactionless_destroy?(project) def self.project_transactionless_destroy?(project)
Feature.enabled?(:project_transactionless_destroy, project, default_enabled: false) Feature.enabled?(:project_transactionless_destroy, project, default_enabled: false)
end end
......
...@@ -24,7 +24,7 @@ module Gitlab ...@@ -24,7 +24,7 @@ module Gitlab
end end
def validate(content, dry_run: false) def validate(content, dry_run: false)
if dry_run && Gitlab::Ci::Features.lint_creates_pipeline_with_dry_run?(@project) if dry_run
simulate_pipeline_creation(content) simulate_pipeline_creation(content)
else else
static_validation(content) static_validation(content)
......
...@@ -123,20 +123,6 @@ RSpec.describe Projects::Ci::LintsController do ...@@ -123,20 +123,6 @@ RSpec.describe Projects::Ci::LintsController do
subject subject
end end
context 'when dry_run feature flag is disabled' do
before do
stub_feature_flags(ci_lint_creates_pipeline_with_dry_run: false)
end
it_behaves_like 'returns a successful validation'
it 'runs validations through YamlProcessor' do
expect(Gitlab::Ci::YamlProcessor).to receive(:new).and_call_original
subject
end
end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment