Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
572c8763
Commit
572c8763
authored
Aug 13, 2020
by
Justin Boyson
Committed by
Paul Slaughter
Aug 13, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable multiline_comments by default
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39370
parent
6aaddc4a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
8 deletions
+14
-8
app/controllers/projects/merge_requests_controller.rb
app/controllers/projects/merge_requests_controller.rb
+1
-1
changelogs/unreleased/jdb-mlc-enable-default.yml
changelogs/unreleased/jdb-mlc-enable-default.yml
+5
-0
doc/user/project/merge_requests/reviewing_and_managing_merge_requests.md
...t/merge_requests/reviewing_and_managing_merge_requests.md
+8
-7
No files found.
app/controllers/projects/merge_requests_controller.rb
View file @
572c8763
...
@@ -33,7 +33,7 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
...
@@ -33,7 +33,7 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
push_frontend_feature_flag
(
:widget_visibility_polling
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:widget_visibility_polling
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:merge_ref_head_comments
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:merge_ref_head_comments
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:mr_commit_neighbor_nav
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:mr_commit_neighbor_nav
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:multiline_comments
,
@project
)
push_frontend_feature_flag
(
:multiline_comments
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:file_identifier_hash
)
push_frontend_feature_flag
(
:file_identifier_hash
)
push_frontend_feature_flag
(
:batch_suggestions
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:batch_suggestions
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:auto_expand_collapsed_diffs
,
@project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:auto_expand_collapsed_diffs
,
@project
,
default_enabled:
true
)
...
...
changelogs/unreleased/jdb-mlc-enable-default.yml
0 → 100644
View file @
572c8763
---
title
:
Enable Multiline Comments by default
merge_request
:
39370
author
:
type
:
changed
doc/user/project/merge_requests/reviewing_and_managing_merge_requests.md
View file @
572c8763
...
@@ -151,11 +151,12 @@ in a Merge Request. To do so, click the **{comment}** **comment** icon in the gu
...
@@ -151,11 +151,12 @@ in a Merge Request. To do so, click the **{comment}** **comment** icon in the gu
### Commenting on multiple lines
### Commenting on multiple lines
> - [Introduced](https://gitlab.com/gitlab-org/ux-research/-/issues/870) in GitLab 13.2.
> - [Introduced](https://gitlab.com/gitlab-org/ux-research/-/issues/870) in GitLab 13.2.
> - It's deployed behind a feature flag, disabled by default.
> - It's deployed behind a feature flag, enabled by default.
> - [Became enabled by default](https://gitlab.com/gitlab-org/gitlab/-/issues/221268) on GitLab 13.3.
> - It's enabled on GitLab.com.
> - It's enabled on GitLab.com.
> - It can be
enabled or dis
abled per-project.
> - It can be
disabled or en
abled per-project.
> - It's recommended for production use.
> - It's recommended for production use.
> - For GitLab self-managed instances, GitLab administrators can opt to [
en
able it](#enable-or-disable-multiline-comments-core-only). **(CORE ONLY)**
> - For GitLab self-managed instances, GitLab administrators can opt to [
dis
able it](#enable-or-disable-multiline-comments-core-only). **(CORE ONLY)**
GitLab provides a way to select which lines of code a comment refers to. After starting a comment
GitLab provides a way to select which lines of code a comment refers to. After starting a comment
a dropdown selector is shown to select the first line that this comment refers to.
a dropdown selector is shown to select the first line that this comment refers to.
...
@@ -178,16 +179,16 @@ It is deployed behind a feature flag that is **disabled by default**.
...
@@ -178,16 +179,16 @@ It is deployed behind a feature flag that is **disabled by default**.
[
GitLab administrators with access to the GitLab Rails console
](
../../../administration/feature_flags.md
)
[
GitLab administrators with access to the GitLab Rails console
](
../../../administration/feature_flags.md
)
can opt to enable it for your instance.
can opt to enable it for your instance.
To
en
able it:
To
dis
able it:
```
ruby
```
ruby
Feature
.
en
able
(
:multiline_comments
)
Feature
.
dis
able
(
:multiline_comments
)
```
```
To
dis
able it:
To
en
able it:
```
ruby
```
ruby
Feature
.
dis
able
(
:multiline_comments
)
Feature
.
en
able
(
:multiline_comments
)
```
```
## Pipeline status in merge requests widgets
## Pipeline status in merge requests widgets
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment