Merge branch 'sh-make-cache-classes-configurable' into 'master'

Make Rails code reloading configurable in development and test

See merge request gitlab-org/gitlab!46836

.gitlab-ci.yml

@@ -65,6 +65,7 @@ variables:
   ES_JAVA_OPTS: "-Xms256m -Xmx256m"
   ELASTIC_URL: "http://elastic:changeme@elasticsearch:9200"
   DOCKER_VERSION: "19.03.0"
+  CACHE_CLASSES: "true"
 
   # Preparing custom clone path to reduce space used by all random forks
   # on GitLab.com's Shared Runners. Our main forks - especially the security

config/environments/development.rb

@@ -4,7 +4,7 @@ Rails.application.configure do
   # In the development environment your application's code is reloaded on
   # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
-  config.cache_classes = false
+  config.cache_classes = Gitlab::Utils.to_boolean(ENV['CACHE_CLASSES'], default: false)
 
   # Show full error reports and disable caching
   config.active_record.verbose_query_logs  = true

config/environments/test.rb

@@ -17,9 +17,7 @@ Rails.application.configure do
   # test suite. You never need to work with it otherwise. Remember that
   # your test database is "scratch space" for the test suite and is wiped
   # and recreated between test runs. Don't rely on the data there!
-
-  # Code doesn't change in CI so we don't need code-reloading
-  config.cache_classes = !!ENV['CI']
+  config.cache_classes = Gitlab::Utils.to_boolean(ENV['CACHE_CLASSES'], default: false)
 
   # Configure static asset server for tests with Cache-Control for performance
   config.assets.compile = false if ENV['CI']