Commit 57de747c authored by Clement Ho's avatar Clement Ho

[skip ci] code review comments

parent f44bac30
...@@ -48,8 +48,7 @@ export default { ...@@ -48,8 +48,7 @@ export default {
eventHub.$on('sidebar.saveUsers', this.saveUsers); eventHub.$on('sidebar.saveUsers', this.saveUsers);
}, },
beforeMount() { beforeMount() {
const element = this.$el; this.field = this.$el.dataset.field;
this.field = element.dataset.field;
}, },
template: ` template: `
<div> <div>
......
...@@ -24,10 +24,12 @@ export default { ...@@ -24,10 +24,12 @@ export default {
timeSpentHumanReadable: { timeSpentHumanReadable: {
type: String, type: String,
required: false, required: false,
default: '',
}, },
timeEstimateHumanReadable: { timeEstimateHumanReadable: {
type: String, type: String,
required: false, required: false,
default: '',
}, },
}, },
methods: { methods: {
......
...@@ -13,24 +13,25 @@ export default { ...@@ -13,24 +13,25 @@ export default {
time_estimate: { time_estimate: {
type: Number, type: Number,
required: true, required: true,
default: 0,
}, },
time_spent: { time_spent: {
type: Number, type: Number,
required: true, required: true,
default: 0,
}, },
human_time_estimate: { human_time_estimate: {
type: String, type: String,
required: false, required: false,
default: '',
}, },
human_time_spent: { human_time_spent: {
type: String, type: String,
required: false, required: false,
default: '',
}, },
rootPath: { rootPath: {
type: String, type: String,
required: true, required: true,
default: '',
}, },
}, },
data() { data() {
......
import Vue from 'vue'; import Vue from 'vue';
import VueResource from 'vue-resource'; import VueResource from 'vue-resource';
import '../../vue_shared/vue_resource_interceptor';
Vue.use(VueResource); Vue.use(VueResource);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment