Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5896c5f9
Commit
5896c5f9
authored
May 06, 2020
by
alinamihaila
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable telemetry reviews for snowplow events
parent
ca6aa800
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
2 deletions
+14
-2
danger/telemetry/Dangerfile
danger/telemetry/Dangerfile
+14
-2
No files found.
danger/telemetry/Dangerfile
View file @
5896c5f9
...
...
@@ -9,12 +9,24 @@ USAGE_DATA_FILES_MESSAGE = <<~MSG
For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended:
MSG
tracking_files
=
[
'lib/gitlab/tracking.rb'
,
'spec/lib/gitlab/tracking_spec.rb'
,
'app/helpers/tracking_helper.rb'
,
'spec/helpers/tracking_helper_spec.rb'
,
'app/assets/javascripts/tracking.js'
,
'spec/frontend/tracking_spec.js'
]
usage_data_changed_files
=
git
.
modified_files
.
grep
(
%r{usage_data}
)
snowplow_events_changed_files
=
git
.
modified_files
&
tracking_files
changed_files
=
(
usage_data_changed_files
+
snowplow_events_changed_files
)
if
usage_data_
changed_files
.
any?
if
changed_files
.
any?
warn
format
(
TELEMETRY_CHANGED_FILES_MESSAGE
)
markdown
(
USAGE_DATA_FILES_MESSAGE
+
helper
.
markdown_list
(
usage_data_
changed_files
))
markdown
(
USAGE_DATA_FILES_MESSAGE
+
helper
.
markdown_list
(
changed_files
))
telemetry_labels
=
[
'telemetry'
]
telemetry_labels
<<
'telemetry::review pending'
unless
helper
.
mr_has_labels?
(
'telemetry::reviewed'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment