Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5906cca0
Commit
5906cca0
authored
Aug 21, 2016
by
Luke Bennett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed timing issue with selecting parallel or inline view types
parent
884baf26
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
5 deletions
+3
-5
spec/features/merge_requests/diff_notes_spec.rb
spec/features/merge_requests/diff_notes_spec.rb
+3
-5
No files found.
spec/features/merge_requests/diff_notes_spec.rb
View file @
5906cca0
...
@@ -17,8 +17,7 @@ feature 'Diff notes', js: true, feature: true do
...
@@ -17,8 +17,7 @@ feature 'Diff notes', js: true, feature: true do
context
'when hovering over the parallel view diff file'
do
context
'when hovering over the parallel view diff file'
do
before
(
:each
)
do
before
(
:each
)
do
visit
diffs_namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
)
visit
diffs_namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
,
view:
'parallel'
)
click_link
'Side-by-side'
end
end
context
'with an old line on the left and no line on the right'
do
context
'with an old line on the left and no line on the right'
do
...
@@ -74,8 +73,7 @@ feature 'Diff notes', js: true, feature: true do
...
@@ -74,8 +73,7 @@ feature 'Diff notes', js: true, feature: true do
context
'when hovering over the inline view diff file'
do
context
'when hovering over the inline view diff file'
do
before
do
before
do
visit
diffs_namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
)
visit
diffs_namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
,
view:
'inline'
)
click_link
'Inline'
end
end
context
'with a new line'
do
context
'with a new line'
do
...
@@ -109,7 +107,6 @@ feature 'Diff notes', js: true, feature: true do
...
@@ -109,7 +107,6 @@ feature 'Diff notes', js: true, feature: true do
expect
(
line
[
:num
]).
to
have_css
comment_button_class
expect
(
line
[
:num
]).
to
have_css
comment_button_class
comment_on_line
(
line_holder
,
line
)
comment_on_line
(
line_holder
,
line
)
wait_for_ajax
assert_comment_persistence
(
line_holder
)
assert_comment_persistence
(
line_holder
)
end
end
...
@@ -150,6 +147,7 @@ feature 'Diff notes', js: true, feature: true do
...
@@ -150,6 +147,7 @@ feature 'Diff notes', js: true, feature: true do
notes_holder_input
.
fill_in
'note[note]'
,
with:
test_note_comment
notes_holder_input
.
fill_in
'note[note]'
,
with:
test_note_comment
click_button
'Comment'
click_button
'Comment'
wait_for_ajax
end
end
def
assert_comment_persistence
(
line_holder
)
def
assert_comment_persistence
(
line_holder
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment