Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5976410b
Commit
5976410b
authored
Feb 05, 2018
by
Matija Čupić
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor UserCalloutsController enum check
parent
a85b85e1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
7 deletions
+3
-7
app/controllers/user_callouts_controller.rb
app/controllers/user_callouts_controller.rb
+3
-7
No files found.
app/controllers/user_callouts_controller.rb
View file @
5976410b
class
UserCalloutsController
<
ApplicationController
class
UserCalloutsController
<
ApplicationController
def
create
def
create
if
check_feature_name
&&
ensure_callout
if
ensure_callout
.
persisted?
respond_to
do
|
format
|
respond_to
do
|
format
|
format
.
json
{
head
:ok
}
format
.
json
{
head
:ok
}
end
end
...
@@ -13,15 +13,11 @@ class UserCalloutsController < ApplicationController
...
@@ -13,15 +13,11 @@ class UserCalloutsController < ApplicationController
private
private
def
check_feature_name
UserCallout
.
feature_names
.
keys
.
include?
(
callout_param
)
end
def
ensure_callout
def
ensure_callout
current_user
.
callouts
.
find_or_create_by
(
feature_name:
callout_param
)
current_user
.
callouts
.
find_or_create_by
(
feature_name:
UserCallout
.
feature_names
[
feature_name
]
)
end
end
def
callout_param
def
feature_name
params
.
require
(
:feature_name
)
params
.
require
(
:feature_name
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment