Merge branch '356598-feature-flag-cleanup-diff_settings_usage_data' into 'master'

Remov diff_settings_usage_data feature flag

See merge request gitlab-org/gitlab!84539

app/assets/javascripts/diffs/components/app.vue

@@ -347,36 +347,34 @@ export default {
       this.setHighlightedRow(id.split('diff-content').pop().slice(1));
     }
 
-    if (window.gon?.features?.diffSettingsUsageData) {
-      const events = [];
+    const events = [];
 
-      if (this.renderTreeList) {
-        events.push(TRACKING_FILE_BROWSER_TREE);
-      } else {
-        events.push(TRACKING_FILE_BROWSER_LIST);
-      }
-
-      if (this.diffViewType === INLINE_DIFF_VIEW_TYPE) {
-        events.push(TRACKING_DIFF_VIEW_INLINE);
-      } else {
-        events.push(TRACKING_DIFF_VIEW_PARALLEL);
-      }
+    if (this.renderTreeList) {
+      events.push(TRACKING_FILE_BROWSER_TREE);
+    } else {
+      events.push(TRACKING_FILE_BROWSER_LIST);
+    }
 
-      if (this.showWhitespace) {
-        events.push(TRACKING_WHITESPACE_SHOW);
-      } else {
-        events.push(TRACKING_WHITESPACE_HIDE);
-      }
+    if (this.diffViewType === INLINE_DIFF_VIEW_TYPE) {
+      events.push(TRACKING_DIFF_VIEW_INLINE);
+    } else {
+      events.push(TRACKING_DIFF_VIEW_PARALLEL);
+    }
 
-      if (this.viewDiffsFileByFile) {
-        events.push(TRACKING_SINGLE_FILE_MODE);
-      } else {
-        events.push(TRACKING_MULTIPLE_FILES_MODE);
-      }
+    if (this.showWhitespace) {
+      events.push(TRACKING_WHITESPACE_SHOW);
+    } else {
+      events.push(TRACKING_WHITESPACE_HIDE);
+    }
 
-      queueRedisHllEvents(events);
+    if (this.viewDiffsFileByFile) {
+      events.push(TRACKING_SINGLE_FILE_MODE);
+    } else {
+      events.push(TRACKING_MULTIPLE_FILES_MODE);
     }
 
+    queueRedisHllEvents(events);
+
     this.subscribeToVirtualScrollingEvents();
   },
   beforeCreate() {

app/assets/javascripts/diffs/store/actions.js

@@ -376,9 +376,7 @@ export const setInlineDiffViewType = ({ commit }) => {
   const url = mergeUrlParams({ view: INLINE_DIFF_VIEW_TYPE }, window.location.href);
   historyPushState(url);
 
-  if (window.gon?.features?.diffSettingsUsageData) {
-    queueRedisHllEvents([TRACKING_CLICK_DIFF_VIEW_SETTING, TRACKING_DIFF_VIEW_INLINE]);
-  }
+  queueRedisHllEvents([TRACKING_CLICK_DIFF_VIEW_SETTING, TRACKING_DIFF_VIEW_INLINE]);
 };
 
 export const setParallelDiffViewType = ({ commit }) => {
@@ -388,9 +386,7 @@ export const setParallelDiffViewType = ({ commit }) => {
   const url = mergeUrlParams({ view: PARALLEL_DIFF_VIEW_TYPE }, window.location.href);
   historyPushState(url);
 
-  if (window.gon?.features?.diffSettingsUsageData) {
-    queueRedisHllEvents([TRACKING_CLICK_DIFF_VIEW_SETTING, TRACKING_DIFF_VIEW_PARALLEL]);
-  }
+  queueRedisHllEvents([TRACKING_CLICK_DIFF_VIEW_SETTING, TRACKING_DIFF_VIEW_PARALLEL]);
 };
 
 export const showCommentForm = ({ commit }, { lineCode, fileHash }) => {
@@ -576,7 +572,7 @@ export const setRenderTreeList = ({ commit }, { renderTreeList, trackClick = tru
 
   localStorage.setItem(TREE_LIST_STORAGE_KEY, renderTreeList);
 
-  if (window.gon?.features?.diffSettingsUsageData && trackClick) {
+  if (trackClick) {
     const events = [TRACKING_CLICK_FILE_BROWSER_SETTING];
 
     if (renderTreeList) {
@@ -600,7 +596,7 @@ export const setShowWhitespace = async (
   commit(types.SET_SHOW_WHITESPACE, showWhitespace);
   notesEventHub.$emit('refetchDiffData');
 
-  if (window.gon?.features?.diffSettingsUsageData && trackClick) {
+  if (trackClick) {
     const events = [TRACKING_CLICK_WHITESPACE_SETTING];
 
     if (showWhitespace) {
@@ -827,18 +823,16 @@ export const navigateToDiffFileIndex = ({ commit, state }, index) => {
 export const setFileByFile = ({ state, commit }, { fileByFile }) => {
   commit(types.SET_FILE_BY_FILE, fileByFile);
 
-  if (window.gon?.features?.diffSettingsUsageData) {
-    const events = [TRACKING_CLICK_SINGLE_FILE_SETTING];
-
-    if (fileByFile) {
-      events.push(TRACKING_SINGLE_FILE_MODE);
-    } else {
-      events.push(TRACKING_MULTIPLE_FILES_MODE);
-    }
+  const events = [TRACKING_CLICK_SINGLE_FILE_SETTING];
 
-    queueRedisHllEvents(events);
+  if (fileByFile) {
+    events.push(TRACKING_SINGLE_FILE_MODE);
+  } else {
+    events.push(TRACKING_MULTIPLE_FILES_MODE);
   }
 
+  queueRedisHllEvents(events);
+
   return axios
     .put(state.endpointUpdateUser, {
       view_diffs_file_by_file: fileByFile,

app/controllers/projects/merge_requests_controller.rb

@@ -43,10 +43,6 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
     push_frontend_feature_flag(:secure_vulnerability_training, project, default_enabled: :yaml)
     push_frontend_feature_flag(:issue_assignees_widget, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:realtime_labels, project, default_enabled: :yaml)
-
-    # Usage data feature flags
-    #
-    push_frontend_feature_flag(:diff_settings_usage_data, default_enabled: :yaml)
   end
 
   before_action do

config/feature_flags/development/diff_settings_usage_data.yml

----
-name: diff_settings_usage_data
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59979
-rollout_issue_url:
-milestone: '13.11'
-type: development
-group: group::code review
-default_enabled: true

lib/gitlab/usage_data_counters/known_events/code_review_events.yml

@@ -178,62 +178,50 @@
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_click_single_file_mode_setting
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_click_file_browser_setting
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_click_whitespace_setting
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_diff_view_inline
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_diff_view_parallel
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_file_browser_tree_view
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_file_browser_list_view
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_diff_show_whitespace
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_diff_hide_whitespace
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_diff_single_file
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_diff_multiple_files
   redis_slot: code_review
   category: code_review
   aggregation: weekly
-  feature_flag: diff_settings_usage_data
 - name: i_code_review_user_load_conflict_ui
   redis_slot: code_review
   category: code_review