Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5992b607
Commit
5992b607
authored
Jan 21, 2021
by
Sarah Groff Hennigh-Palermo
Committed by
Mark Florian
Jan 21, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add user-actor feature flag for pipelines
Update related specs and fe checks
parent
a7945056
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
19 additions
and
4 deletions
+19
-4
app/assets/javascripts/pipelines/pipeline_details_bundle.js
app/assets/javascripts/pipelines/pipeline_details_bundle.js
+5
-2
app/controllers/projects/pipelines_controller.rb
app/controllers/projects/pipelines_controller.rb
+2
-1
app/views/projects/pipelines/show.html.haml
app/views/projects/pipelines/show.html.haml
+1
-1
config/feature_flags/development/graphql_pipeline_details_users.yml
...ture_flags/development/graphql_pipeline_details_users.yml
+8
-0
ee/spec/features/projects/pipelines/pipeline_spec.rb
ee/spec/features/projects/pipelines/pipeline_spec.rb
+1
-0
spec/features/projects/pipelines/pipeline_spec.rb
spec/features/projects/pipelines/pipeline_spec.rb
+1
-0
spec/features/projects/pipelines/pipelines_spec.rb
spec/features/projects/pipelines/pipelines_spec.rb
+1
-0
No files found.
app/assets/javascripts/pipelines/pipeline_details_bundle.js
View file @
5992b607
...
...
@@ -136,10 +136,13 @@ export default async function () {
createTestDetails
();
createDagApp
();
const
canShowNewPipelineDetails
=
gon
.
features
.
graphqlPipelineDetails
||
gon
.
features
.
graphqlPipelineDetailsUsers
;
const
{
dataset
}
=
document
.
querySelector
(
SELECTORS
.
PIPELINE_DETAILS
);
let
mediator
;
if
(
!
gon
.
features
.
graphqlPipelineHeader
||
!
gon
.
features
.
graphql
PipelineDetails
)
{
if
(
!
gon
.
features
.
graphqlPipelineHeader
||
!
canShowNew
PipelineDetails
)
{
try
{
const
{
default
:
PipelinesMediator
}
=
await
import
(
/* webpackChunkName: 'PipelinesMediator' */
'
./pipeline_details_mediator
'
...
...
@@ -151,7 +154,7 @@ export default async function () {
}
}
if
(
gon
.
features
.
graphql
PipelineDetails
)
{
if
(
canShowNew
PipelineDetails
)
{
try
{
const
{
createPipelinesDetailApp
}
=
await
import
(
/* webpackChunkName: 'createPipelinesDetailApp' */
'
./pipeline_details_graph
'
...
...
app/controllers/projects/pipelines_controller.rb
View file @
5992b607
...
...
@@ -16,7 +16,8 @@ class Projects::PipelinesController < Projects::ApplicationController
push_frontend_feature_flag
(
:pipelines_security_report_summary
,
project
)
push_frontend_feature_flag
(
:new_pipeline_form
,
project
,
default_enabled:
true
)
push_frontend_feature_flag
(
:graphql_pipeline_header
,
project
,
type: :development
,
default_enabled:
false
)
push_frontend_feature_flag
(
:graphql_pipeline_details
,
project
,
type: :development
,
default_enabled:
false
)
push_frontend_feature_flag
(
:graphql_pipeline_details
,
project
,
type: :development
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:graphql_pipeline_details_users
,
current_user
,
type: :development
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:new_pipeline_form_prefilled_vars
,
project
,
type: :development
,
default_enabled:
true
)
end
before_action
:ensure_pipeline
,
only:
[
:show
]
...
...
app/views/projects/pipelines/show.html.haml
View file @
5992b607
...
...
@@ -6,7 +6,7 @@
-
add_page_specific_style
'page_bundles/reports'
-
add_page_specific_style
'page_bundles/ci_status'
-
if
Feature
.
enabled?
(
:graphql_pipeline_details
,
@project
)
-
if
Feature
.
enabled?
(
:graphql_pipeline_details
,
@project
,
default_enabled: :yaml
)
||
Feature
.
enabled?
(
:graphql_pipeline_details_users
,
@current_user
,
default_enabled: :yaml
)
-
add_page_startup_graphql_call
(
'pipelines/get_pipeline_details'
,
{
projectPath:
@project
.
full_path
,
iid:
@pipeline
.
iid
})
.js-pipeline-container
{
data:
{
controller_action:
"#{controller.action_name}"
}
}
...
...
config/feature_flags/development/graphql_pipeline_details_users.yml
0 → 100644
View file @
5992b607
---
name
:
graphql_pipeline_details_users
introduced_by_url
:
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/299112
milestone
:
'
13.9'
type
:
development
group
:
group::pipeline authoring
default_enabled
:
false
ee/spec/features/projects/pipelines/pipeline_spec.rb
View file @
5992b607
...
...
@@ -8,6 +8,7 @@ RSpec.describe 'Pipeline', :js do
before
do
stub_feature_flags
(
graphql_pipeline_details:
false
)
stub_feature_flags
(
graphql_pipeline_details_users:
false
)
sign_in
(
user
)
project
.
add_developer
(
user
)
...
...
spec/features/projects/pipelines/pipeline_spec.rb
View file @
5992b607
...
...
@@ -15,6 +15,7 @@ RSpec.describe 'Pipeline', :js do
sign_in
(
user
)
project
.
add_role
(
user
,
role
)
stub_feature_flags
(
graphql_pipeline_details:
false
)
stub_feature_flags
(
graphql_pipeline_details_users:
false
)
end
shared_context
'pipeline builds'
do
...
...
spec/features/projects/pipelines/pipelines_spec.rb
View file @
5992b607
...
...
@@ -13,6 +13,7 @@ RSpec.describe 'Pipelines', :js do
before
do
sign_in
(
user
)
stub_feature_flags
(
graphql_pipeline_details:
false
)
stub_feature_flags
(
graphql_pipeline_details_users:
false
)
project
.
add_developer
(
user
)
project
.
update!
(
auto_devops_attributes:
{
enabled:
false
})
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment