Commit 5a215bd9 authored by Dallas Reedy's avatar Dallas Reedy Committed by Kati Paizee

Update copy for the expose free users to MR approvals experiment

- Just a few changes to the copy to tighten up the messaging and present
  the values first
- Also updated the related feature spec as it is using some of the text
  to detect the presence of the promotion
parent 5401c260
......@@ -167,14 +167,13 @@ export const MR_APPROVALS_PROMO_TRACKING_EVENTS = {
};
export const MR_APPROVALS_PROMO_I18N = {
accordionTitle: s__('ApprovalRule|Approval rules'),
learnMore: s__('ApprovalRule|Learn more about merge request approval.'),
promoTitle: s__('ApprovalRule|Add required approvers to improve your code review process'),
learnMore: s__('ApprovalRule|Learn more about merge request approval rules.'),
promoTitle: s__("ApprovalRule|Improve your organization's code review with required approvals."),
summary: __('Approvals are optional.'),
tryNow: s__('ApprovalRule|Try it for free'),
tryNow: s__('ApprovalRule|Try for free'),
valueStatements: [
s__('ApprovalRule|Assign approvers by area of expertise.'),
s__('ApprovalRule|Increase your organization’s code quality.'),
s__('ApprovalRule|Reduce the overall time to merge.'),
s__('ApprovalRule|Let GitLab designate eligible approvers based on the files changed.'),
s__('ApprovalRule|Select eligible approvers by expertise or files changed.'),
s__('ApprovalRule|Increase quality and maintain standards.'),
s__('ApprovalRule|Reduce your time to merge.'),
],
};
......@@ -6,6 +6,7 @@ RSpec.describe 'user sees MR approvals promo', :js do
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :repository, group: group) }
let_it_be(:promo_title) { s_("ApprovalRule|Improve your organization's code review with required approvals.") }
before do
group.add_owner(user)
......@@ -25,7 +26,7 @@ RSpec.describe 'user sees MR approvals promo', :js do
end
it 'shows the promo text' do
expect(page).to have_text('Add required approvers to improve your code review process')
expect(page).to have_text(promo_title)
end
end
......@@ -37,7 +38,7 @@ RSpec.describe 'user sees MR approvals promo', :js do
end
it 'shows the promo text' do
expect(page).to have_text('Add required approvers to improve your code review process')
expect(page).to have_text(promo_title)
end
end
end
......@@ -4374,9 +4374,6 @@ msgstr ""
msgid "ApprovalRule|Add approvers"
msgstr ""
msgid "ApprovalRule|Add required approvers to improve your code review process"
msgstr ""
msgid "ApprovalRule|All scanners"
msgstr ""
......@@ -4407,9 +4404,6 @@ msgstr ""
msgid "ApprovalRule|Approvers"
msgstr ""
msgid "ApprovalRule|Assign approvers by area of expertise."
msgstr ""
msgid "ApprovalRule|Confirmed"
msgstr ""
......@@ -4419,13 +4413,13 @@ msgstr ""
msgid "ApprovalRule|Examples: QA, Security."
msgstr ""
msgid "ApprovalRule|Increase your organization’s code quality."
msgid "ApprovalRule|Improve your organization's code review with required approvals."
msgstr ""
msgid "ApprovalRule|Learn more about merge request approval."
msgid "ApprovalRule|Increase quality and maintain standards."
msgstr ""
msgid "ApprovalRule|Let GitLab designate eligible approvers based on the files changed."
msgid "ApprovalRule|Learn more about merge request approval rules."
msgstr ""
msgid "ApprovalRule|Name"
......@@ -4452,7 +4446,7 @@ msgstr ""
msgid "ApprovalRule|Previously detected"
msgstr ""
msgid "ApprovalRule|Reduce the overall time to merge."
msgid "ApprovalRule|Reduce your time to merge."
msgstr ""
msgid "ApprovalRule|Resolved"
......@@ -4467,6 +4461,9 @@ msgstr ""
msgid "ApprovalRule|Select All"
msgstr ""
msgid "ApprovalRule|Select eligible approvers by expertise or files changed."
msgstr ""
msgid "ApprovalRule|Select scanners"
msgstr ""
......@@ -4482,7 +4479,7 @@ msgstr ""
msgid "ApprovalRule|Target branch"
msgstr ""
msgid "ApprovalRule|Try it for free"
msgid "ApprovalRule|Try for free"
msgstr ""
msgid "ApprovalRule|Vulnerabilities allowed"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment