Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5a7f36a6
Commit
5a7f36a6
authored
Jul 09, 2018
by
Mario de la Ossa
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Boards::Lists::CreateService
parent
d8f0ada5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
31 additions
and
3 deletions
+31
-3
ee/app/services/ee/boards/lists/create_service.rb
ee/app/services/ee/boards/lists/create_service.rb
+3
-3
ee/spec/services/ee/boards/lists/create_service_spec.rb
ee/spec/services/ee/boards/lists/create_service_spec.rb
+28
-0
No files found.
ee/app/services/ee/boards/lists/create_service.rb
View file @
5a7f36a6
...
...
@@ -24,12 +24,12 @@ module EE
end
def
find_user
(
board
)
user_ids
=
user_finder
(
board
).
select
(
:user_id
)
::
User
.
where
(
id:
user_ids
).
find
(
params
[
:assignee_id
])
user_ids
=
user_finder
(
board
).
execute
.
select
(
:user_id
)
::
User
.
where
(
id:
user_ids
).
find
(
params
[
'assignee_id'
])
end
def
user_finder
(
board
)
@user_finder
||=
Boards
::
UsersFinder
.
new
(
board
,
current_user
)
@user_finder
||=
::
Boards
::
UsersFinder
.
new
(
board
,
current_user
)
end
end
end
...
...
ee/spec/services/ee/boards/lists/create_service_spec.rb
0 → 100644
View file @
5a7f36a6
require
'spec_helper'
describe
Boards
::
Lists
::
CreateService
do
describe
'#execute'
do
let
(
:parent
)
{
create
(
:project
)
}
let
(
:board
)
{
create
(
:board
,
project:
parent
)
}
let
(
:label
)
{
create
(
:label
,
project:
parent
,
name:
'in-progress'
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:other_user
)
{
create
(
:user
)
}
subject
(
:service
)
{
described_class
.
new
(
parent
,
user
,
'assignee_id'
=>
other_user
.
id
)
}
before
do
parent
.
add_developer
(
user
)
parent
.
add_developer
(
other_user
)
stub_licensed_features
(
board_assignee_lists:
true
)
end
it
'creates a new assignee list'
do
list
=
service
.
execute
(
board
)
expect
(
list
.
list_type
).
to
eq
(
'assignee'
)
expect
(
list
).
to
be_valid
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment