Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5c2f3eed
Commit
5c2f3eed
authored
Apr 26, 2021
by
Huzaifa Iftikhar
Committed by
Matthias Käppler
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Rails/SaveBang Rubocop offenses for wiki_page models
parent
c765eb69
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
4 deletions
+10
-4
.rubocop.yml
.rubocop.yml
+3
-0
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-2
changelogs/unreleased/issue-220040-fix-rails-savebang-wiki-model.yml
...unreleased/issue-220040-fix-rails-savebang-wiki-model.yml
+5
-0
spec/models/wiki_page/meta_spec.rb
spec/models/wiki_page/meta_spec.rb
+2
-2
No files found.
.rubocop.yml
View file @
5c2f3eed
...
@@ -575,6 +575,9 @@ Rails/SaveBang:
...
@@ -575,6 +575,9 @@ Rails/SaveBang:
-
'
ee/spec/**/*.rb'
-
'
ee/spec/**/*.rb'
-
'
qa/spec/**/*.rb'
-
'
qa/spec/**/*.rb'
-
'
qa/qa/specs/**/*.rb'
-
'
qa/qa/specs/**/*.rb'
Exclude
:
-
spec/models/wiki_page/**/*
-
spec/models/wiki_page_spec.rb
Cop/PutProjectRoutesUnderScope
:
Cop/PutProjectRoutesUnderScope
:
Include
:
Include
:
...
...
.rubocop_manual_todo.yml
View file @
5c2f3eed
...
@@ -245,8 +245,6 @@ Rails/SaveBang:
...
@@ -245,8 +245,6 @@ Rails/SaveBang:
-
'
spec/models/user_preference_spec.rb'
-
'
spec/models/user_preference_spec.rb'
-
'
spec/models/user_spec.rb'
-
'
spec/models/user_spec.rb'
-
'
spec/models/user_status_spec.rb'
-
'
spec/models/user_status_spec.rb'
-
'
spec/models/wiki_page/meta_spec.rb'
-
'
spec/models/wiki_page_spec.rb'
Rails/TimeZone
:
Rails/TimeZone
:
Enabled
:
true
Enabled
:
true
...
...
changelogs/unreleased/issue-220040-fix-rails-savebang-wiki-model.yml
0 → 100644
View file @
5c2f3eed
---
title
:
Fix Rails/SaveBang Rubocop offenses for wiki_page models
merge_request
:
57899
author
:
Huzaifa Iftikhar @huzaifaiftikhar
type
:
fixed
spec/models/wiki_page/meta_spec.rb
View file @
5c2f3eed
...
@@ -42,7 +42,7 @@ RSpec.describe WikiPage::Meta do
...
@@ -42,7 +42,7 @@ RSpec.describe WikiPage::Meta do
subject
{
described_class
.
find
(
meta
.
id
)
}
subject
{
described_class
.
find
(
meta
.
id
)
}
let_it_be
(
:meta
)
do
let_it_be
(
:meta
)
do
described_class
.
create
(
title:
generate
(
:wiki_page_title
),
project:
project
)
described_class
.
create
!
(
title:
generate
(
:wiki_page_title
),
project:
project
)
end
end
context
'there are no slugs'
do
context
'there are no slugs'
do
...
@@ -183,7 +183,7 @@ RSpec.describe WikiPage::Meta do
...
@@ -183,7 +183,7 @@ RSpec.describe WikiPage::Meta do
# an old slug that = canonical_slug
# an old slug that = canonical_slug
different_slug
=
generate
(
:sluggified_title
)
different_slug
=
generate
(
:sluggified_title
)
create
(
:wiki_page_meta
,
project:
project
,
canonical_slug:
different_slug
)
create
(
:wiki_page_meta
,
project:
project
,
canonical_slug:
different_slug
)
.
slugs
.
create
(
slug:
wiki_page
.
slug
)
.
slugs
.
create
!
(
slug:
wiki_page
.
slug
)
end
end
shared_examples
'metadata examples'
do
shared_examples
'metadata examples'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment