Commit 5db76a3b authored by Sean McGivern's avatar Sean McGivern

Merge branch '40402-time-estimate-system-notes-can-be-confusing' into 'master'

Resolve "Time estimate system notes can be confusing"

Closes #40402

See merge request gitlab-org/gitlab-ce!18326
parents 77d08731 a6ddeb54
......@@ -159,7 +159,7 @@ module SystemNoteService
body = if noteable.time_estimate == 0
"removed time estimate"
else
"changed time estimate to #{parsed_time}"
"changed time estimate to #{parsed_time},"
end
create_note(NoteSummary.new(noteable, project, author, body, action: 'time_tracking'))
......
---
title: Add a comma to the time estimate system notes
merge_request: 18326
author:
type: changed
......@@ -909,7 +909,13 @@ describe SystemNoteService do
it 'sets the note text' do
noteable.update_attribute(:time_estimate, 277200)
expect(subject.note).to eq "changed time estimate to 1w 4d 5h"
expect(subject.note).to eq "changed time estimate to 1w 4d 5h,"
end
it 'appends a comma to separate the note from the update_at time' do
noteable.update_attribute(:time_estimate, 277200)
expect(subject.note).to end_with(',')
end
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment