Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5ddc506c
Commit
5ddc506c
authored
May 06, 2021
by
Alexander Turinske
Committed by
David O'Regan
May 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up code
- simplify css logic - update tests
parent
fea3a2df
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
15 deletions
+6
-15
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_assignees.vue
...ed/alert_details/components/sidebar/sidebar_assignees.vue
+2
-6
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_status.vue
...hared/alert_details/components/sidebar/sidebar_status.vue
+2
-6
spec/frontend/vue_shared/alert_details/sidebar/alert_sidebar_assignees_spec.js
...red/alert_details/sidebar/alert_sidebar_assignees_spec.js
+2
-3
No files found.
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_assignees.vue
View file @
5ddc506c
...
@@ -193,12 +193,8 @@ export default {
...
@@ -193,12 +193,8 @@ export default {
<
template
>
<
template
>
<div
<div
class=
"alert-assignees gl-py-5"
class=
"alert-assignees gl-py-5 gl-w-70p"
:class=
"
{
:class=
"
{ 'gl-border-b-1 gl-border-b-solid gl-border-b-gray-100': !sidebarCollapsed }"
'gl-border-b-1': !sidebarCollapsed,
'gl-border-b-solid': !sidebarCollapsed,
'gl-border-b-gray-100': !sidebarCollapsed,
}"
style="width: 70%"
style="width: 70%"
>
>
<template
v-if=
"sidebarCollapsed"
>
<template
v-if=
"sidebarCollapsed"
>
...
...
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_status.vue
View file @
5ddc506c
...
@@ -66,12 +66,8 @@ export default {
...
@@ -66,12 +66,8 @@ export default {
<
template
>
<
template
>
<div
<div
class=
"alert-status gl-py-5"
class=
"alert-status gl-py-5 gl-w-70p"
:class=
"
{
:class=
"
{ 'gl-border-b-1 gl-border-b-solid gl-border-b-gray-100': !sidebarCollapsed }"
'gl-border-b-1': !sidebarCollapsed,
'gl-border-b-solid': !sidebarCollapsed,
'gl-border-b-gray-100': !sidebarCollapsed,
}"
style="width: 70%"
style="width: 70%"
>
>
<template
v-if=
"sidebarCollapsed"
>
<template
v-if=
"sidebarCollapsed"
>
...
...
spec/frontend/vue_shared/alert_details/sidebar/alert_sidebar_assignees_spec.js
View file @
5ddc506c
...
@@ -31,8 +31,10 @@ describe('Alert Details Sidebar Assignees', () => {
...
@@ -31,8 +31,10 @@ describe('Alert Details Sidebar Assignees', () => {
},
},
];
];
const
findAssigned
=
()
=>
wrapper
.
findByTestId
(
'
assigned-users
'
);
const
findDropdown
=
()
=>
wrapper
.
findComponent
(
GlDropdownItem
);
const
findDropdown
=
()
=>
wrapper
.
findComponent
(
GlDropdownItem
);
const
findSidebarIcon
=
()
=>
wrapper
.
findByTestId
(
'
assignees-icon
'
);
const
findSidebarIcon
=
()
=>
wrapper
.
findByTestId
(
'
assignees-icon
'
);
const
findUnassigned
=
()
=>
wrapper
.
findByTestId
(
'
unassigned-users
'
);
function
mountComponent
({
function
mountComponent
({
data
,
data
,
...
@@ -77,9 +79,6 @@ describe('Alert Details Sidebar Assignees', () => {
...
@@ -77,9 +79,6 @@ describe('Alert Details Sidebar Assignees', () => {
mock
.
restore
();
mock
.
restore
();
});
});
const
findAssigned
=
()
=>
wrapper
.
find
(
'
[data-testid="assigned-users"]
'
);
const
findUnassigned
=
()
=>
wrapper
.
find
(
'
[data-testid="unassigned-users"]
'
);
describe
(
'
sidebar expanded
'
,
()
=>
{
describe
(
'
sidebar expanded
'
,
()
=>
{
const
mockUpdatedMutationResult
=
{
const
mockUpdatedMutationResult
=
{
data
:
{
data
:
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment