Commit 5ddc506c authored by Alexander Turinske's avatar Alexander Turinske Committed by David O'Regan

Clean up code

- simplify css logic
- update tests
parent fea3a2df
...@@ -193,12 +193,8 @@ export default { ...@@ -193,12 +193,8 @@ export default {
<template> <template>
<div <div
class="alert-assignees gl-py-5" class="alert-assignees gl-py-5 gl-w-70p"
:class="{ :class="{ 'gl-border-b-1 gl-border-b-solid gl-border-b-gray-100': !sidebarCollapsed }"
'gl-border-b-1': !sidebarCollapsed,
'gl-border-b-solid': !sidebarCollapsed,
'gl-border-b-gray-100': !sidebarCollapsed,
}"
style="width: 70%" style="width: 70%"
> >
<template v-if="sidebarCollapsed"> <template v-if="sidebarCollapsed">
......
...@@ -66,12 +66,8 @@ export default { ...@@ -66,12 +66,8 @@ export default {
<template> <template>
<div <div
class="alert-status gl-py-5" class="alert-status gl-py-5 gl-w-70p"
:class="{ :class="{ 'gl-border-b-1 gl-border-b-solid gl-border-b-gray-100': !sidebarCollapsed }"
'gl-border-b-1': !sidebarCollapsed,
'gl-border-b-solid': !sidebarCollapsed,
'gl-border-b-gray-100': !sidebarCollapsed,
}"
style="width: 70%" style="width: 70%"
> >
<template v-if="sidebarCollapsed"> <template v-if="sidebarCollapsed">
......
...@@ -31,8 +31,10 @@ describe('Alert Details Sidebar Assignees', () => { ...@@ -31,8 +31,10 @@ describe('Alert Details Sidebar Assignees', () => {
}, },
]; ];
const findAssigned = () => wrapper.findByTestId('assigned-users');
const findDropdown = () => wrapper.findComponent(GlDropdownItem); const findDropdown = () => wrapper.findComponent(GlDropdownItem);
const findSidebarIcon = () => wrapper.findByTestId('assignees-icon'); const findSidebarIcon = () => wrapper.findByTestId('assignees-icon');
const findUnassigned = () => wrapper.findByTestId('unassigned-users');
function mountComponent({ function mountComponent({
data, data,
...@@ -77,9 +79,6 @@ describe('Alert Details Sidebar Assignees', () => { ...@@ -77,9 +79,6 @@ describe('Alert Details Sidebar Assignees', () => {
mock.restore(); mock.restore();
}); });
const findAssigned = () => wrapper.find('[data-testid="assigned-users"]');
const findUnassigned = () => wrapper.find('[data-testid="unassigned-users"]');
describe('sidebar expanded', () => { describe('sidebar expanded', () => {
const mockUpdatedMutationResult = { const mockUpdatedMutationResult = {
data: { data: {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment