Merge branch 'pl-rubocop-have-gitlab-http-status-spec-features' into 'master'

Enable cop HaveGitlabHttpStatus in feature specs

See merge request gitlab-org/gitlab!23554

.rubocop.yml

@@ -348,10 +348,11 @@ RSpec/HaveGitlabHttpStatus:
   Include:
     - 'spec/support/shared_examples/**/*'
     - 'ee/spec/support/shared_examples/**/*'
+    - 'spec/features/**/*'
+    - 'ee/spec/features/**/*'
 
 Style/MultilineWhenThen:
   Enabled: false
 
 Style/FloatDivision:
   Enabled: false
-  
\ No newline at end of file

ee/spec/features/groups/dependency_proxy_spec.rb

@@ -91,7 +91,7 @@ describe 'Group Dependency Proxy' do
 
           visit path
 
-          expect(page).to have_gitlab_http_status(404)
+          expect(page).to have_gitlab_http_status(:not_found)
         end
       end
 
@@ -101,7 +101,7 @@ describe 'Group Dependency Proxy' do
 
           visit path
 
-          expect(page).to have_gitlab_http_status(404)
+          expect(page).to have_gitlab_http_status(:not_found)
         end
       end
     end

ee/spec/features/groups/packages_spec.rb

@@ -28,7 +28,7 @@ describe 'Group Packages' do
       it 'gives 404' do
         visit_group_packages
 
-        expect(page).to have_gitlab_http_status(404)
+        expect(page).to have_gitlab_http_status(:not_found)
       end
     end
 
@@ -40,7 +40,7 @@ describe 'Group Packages' do
       it 'gives 404' do
         visit_group_packages
 
-        expect(page).to have_gitlab_http_status(404)
+        expect(page).to have_gitlab_http_status(:not_found)
       end
     end
 

ee/spec/features/groups/usage_quotas_spec.rb

@@ -54,7 +54,7 @@ describe 'Groups > Usage Quotas' do
       it 'renders a 404' do
         visit_pipeline_quota_page
 
-        expect(page).to have_http_status(:not_found)
+        expect(page).to have_gitlab_http_status(:not_found)
       end
     end
   end
@@ -151,7 +151,7 @@ describe 'Groups > Usage Quotas' do
     it 'does not show subproject' do
       visit_pipeline_quota_page
 
-      expect(page).to have_http_status(:not_found)
+      expect(page).to have_gitlab_http_status(:not_found)
     end
   end
 

ee/spec/features/projects/services/user_activates_github_spec.rb

@@ -21,7 +21,7 @@ describe 'User activates GitHub Service' do
     it 'renders 404 when trying to access service settings directly' do
       visit edit_project_service_path(project, :github)
 
-      expect(page).to have_gitlab_http_status(404)
+      expect(page).to have_gitlab_http_status(:not_found)
     end
   end
 

ee/spec/features/projects/settings/protected_environments_spec.rb

@@ -28,7 +28,7 @@ describe 'Protected Environments' do
     end
 
     it 'does not have access to Protected Environments settings' do
-      expect(page).to have_gitlab_http_status(404)
+      expect(page).to have_gitlab_http_status(:not_found)
     end
   end
 
@@ -40,7 +40,7 @@ describe 'Protected Environments' do
     end
 
     it 'has access to Protected Environments settings' do
-      expect(page).to have_gitlab_http_status(200)
+      expect(page).to have_gitlab_http_status(:ok)
     end
 
     it 'allows seeing a list of protected environments' do
@@ -103,7 +103,7 @@ describe 'Protected Environments' do
         it 'shows setting page correctly' do
           visit project_settings_ci_cd_path(project)
 
-          expect(page).to have_gitlab_http_status(200)
+          expect(page).to have_gitlab_http_status(:ok)
         end
       end
     end

spec/features/profiles/password_spec.rb

@@ -63,7 +63,7 @@ describe 'Profile > Password' do
 
         visit edit_profile_password_path
 
-        expect(page).to have_gitlab_http_status(404)
+        expect(page).to have_gitlab_http_status(:not_found)
       end
     end
 
@@ -73,7 +73,7 @@ describe 'Profile > Password' do
       it 'renders 404' do
         visit edit_profile_password_path
 
-        expect(page).to have_gitlab_http_status(404)
+        expect(page).to have_gitlab_http_status(:not_found)
       end
     end
   end

spec/features/projects/badges/coverage_spec.rb

@@ -54,7 +54,7 @@ describe 'test coverage badge' do
     it 'user requests test coverage badge image' do
       show_test_coverage_badge
 
-      expect(page).to have_gitlab_http_status(404)
+      expect(page).to have_gitlab_http_status(:not_found)
     end
   end
 

spec/features/projects/tags/user_views_tags_spec.rb

@@ -7,7 +7,7 @@ describe 'User views tags', :feature do
       it do
         visit project_tags_path(project, format: :atom)
 
-        expect(page).to have_gitlab_http_status(200)
+        expect(page).to have_gitlab_http_status(:ok)
       end
     end