Merge branch 'georgekoltsov/fix-epics-pipeline' into 'master'

Fix user reference transformation in EpicsPipeline

See merge request gitlab-org/gitlab!58913

changelogs/unreleased/georgekoltsov-fix-epics-pipeline.yml

+---
+title: Fix user reference transformation in EpicsPipeline
+merge_request: 58913
+author:
+type: fixed

ee/lib/ee/bulk_imports/groups/pipelines/epics_pipeline.rb

@@ -11,8 +11,7 @@ module EE
             query: EE::BulkImports::Groups::Graphql::GetEpicsQuery
 
           transformer ::BulkImports::Common::Transformers::ProhibitedAttributesTransformer
-          transformer ::BulkImports::Common::Transformers::UserReferenceTransformer,
-            reference: :author
+          transformer ::BulkImports::Common::Transformers::UserReferenceTransformer, reference: 'author'
           transformer EE::BulkImports::Groups::Transformers::EpicAttributesTransformer
 
           def transform(_, data)

ee/spec/lib/ee/bulk_imports/groups/pipelines/epics_pipeline_spec.rb

@@ -125,7 +125,7 @@ RSpec.describe EE::BulkImports::Groups::Pipelines::EpicsPipeline, :clean_gitlab_
       expect(described_class.transformers)
         .to contain_exactly(
           { klass: BulkImports::Common::Transformers::ProhibitedAttributesTransformer, options: nil },
-          { klass: BulkImports::Common::Transformers::UserReferenceTransformer, options: { reference: :author } },
+          { klass: BulkImports::Common::Transformers::UserReferenceTransformer, options: { reference: 'author' } },
           { klass: EE::BulkImports::Groups::Transformers::EpicAttributesTransformer, options: nil }
         )
     end

lib/bulk_imports/common/transformers/user_reference_transformer.rb

@@ -12,7 +12,7 @@ module BulkImports
         DEFAULT_REFERENCE = 'user'
 
         def initialize(options = {})
-          @reference = options[:reference] || DEFAULT_REFERENCE
+          @reference = options[:reference].to_s.presence || DEFAULT_REFERENCE
           @suffixed_reference = "#{@reference}_id"
         end
 

spec/lib/bulk_imports/common/transformers/user_reference_transformer_spec.rb

@@ -52,19 +52,26 @@ RSpec.describe BulkImports::Common::Transformers::UserReferenceTransformer do
     end
 
     context 'when custom reference is provided' do
-      it 'updates provided reference' do
-        hash = {
-          'author' => {
-            'public_email' => user.email
+      shared_examples 'updates provided reference' do |reference|
+        let(:hash) do
+          {
+            'author' => {
+              'public_email' => user.email
+            }
           }
-        }
+        end
 
-        transformer = described_class.new(reference: 'author')
-        result = transformer.transform(context, hash)
+        it 'updates provided reference' do
+          transformer = described_class.new(reference: reference)
+          result = transformer.transform(context, hash)
 
-        expect(result['author']).to be_nil
-        expect(result['author_id']).to eq(user.id)
+          expect(result['author']).to be_nil
+          expect(result['author_id']).to eq(user.id)
+        end
       end
+
+      include_examples 'updates provided reference', 'author'
+      include_examples 'updates provided reference', :author
     end
   end
 end