Commit 60caa0dc authored by Simon Knox's avatar Simon Knox

Don't click button until page JS loaded

We add `.page-initialised` at the end of `deferredInitialisation`,
which is where the userCallbacks are set up

Better way is to disable the inactive button in haml then enable in JS
but
that has some other UI considerations (disabled tooltip while loading)
parent d322b81f
...@@ -56,7 +56,7 @@ RSpec.describe 'Display approaching user count limit banner', :js do ...@@ -56,7 +56,7 @@ RSpec.describe 'Display approaching user count limit banner', :js do
context 'when banner was dismissed' do context 'when banner was dismissed' do
before do before do
visit admin_root_path visit admin_root_path
find('[data-testid="gitlab-ee-license-banner-dismiss"]').click find('body.page-initialised [data-testid="gitlab-ee-license-banner-dismiss"]').click
end end
it_behaves_like 'a hidden banner' it_behaves_like 'a hidden banner'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment