Commit 6153a6b7 authored by Dan Davison's avatar Dan Davison

Merge branch...

Merge branch '250646-qa-failure-in-qa-specs-features-browser_ui-1_manage-login-register_spec-rb' into 'master'

Resolve "QA failure in qa/specs/features/browser_ui/1_manage/login/register_spec.rb"

Closes #250646

See merge request gitlab-org/gitlab!42586
parents c229eee1 30e11a7a
...@@ -22,4 +22,4 @@ ...@@ -22,4 +22,4 @@
- if partial_exists? "registrations/welcome/button" - if partial_exists? "registrations/welcome/button"
= render "registrations/welcome/button" = render "registrations/welcome/button"
- else - else
= f.submit _('Get started!'), class: 'btn-register btn btn-block gl-mb-0 gl-p-3' = f.submit _('Get started!'), class: 'btn-register btn btn-block gl-mb-0 gl-p-3', data: { qa_selector: 'get_started_button' }
...@@ -14,13 +14,6 @@ module QA ...@@ -14,13 +14,6 @@ module QA
element :get_started_button element :get_started_button
end end
end end
private
# override FOSS
def click_get_started_button
click_element :get_started_button if has_element?(:get_started_button)
end
end end
end end
end end
......
...@@ -13,6 +13,10 @@ module QA ...@@ -13,6 +13,10 @@ module QA
element :new_user_accept_terms_checkbox element :new_user_accept_terms_checkbox
end end
view 'app/views/registrations/welcome.html.haml' do
element :get_started_button
end
def sign_up!(user) def sign_up!(user)
fill_element :new_user_name_field, user.name fill_element :new_user_name_field, user.name
fill_element :new_user_username_field, user.username fill_element :new_user_username_field, user.username
...@@ -24,19 +28,13 @@ module QA ...@@ -24,19 +28,13 @@ module QA
signed_in = retry_until do signed_in = retry_until do
click_element :new_user_register_button if has_element?(:new_user_register_button) click_element :new_user_register_button if has_element?(:new_user_register_button)
click_get_started_button click_element :get_started_button if has_element?(:get_started_button)
Page::Main::Menu.perform(&:has_personal_area?) Page::Main::Menu.perform(&:has_personal_area?)
end end
raise "Failed to register and sign in" unless signed_in raise "Failed to register and sign in" unless signed_in
end end
private
# overridden in EE
def click_get_started_button
end
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment