Merge branch 'cngo-improve-header-accessibility' into 'master'

Improve header acccessibility

See merge request gitlab-org/gitlab!33603

app/views/layouts/header/_default.html.haml

@@ -6,6 +6,7 @@
     .header-content
       .title-container
         %h1.title
+          %span.gl-sr-only GitLab
           = link_to root_path, title: _('Dashboard'), id: 'logo' do
             = brand_header_logo
             - logo_text = brand_header_logo_type
@@ -54,6 +55,8 @@
                   = todos_count_format(todos_pending_count)
           %li.nav-item.header-help.dropdown.d-none.d-md-block
             = link_to help_path, class: 'header-help-dropdown-toggle', data: { toggle: "dropdown" } do
+              %span.gl-sr-only
+                = s_('Nav|Help')
               = sprite_icon('question', size: 16)
               = sprite_icon('angle-down', css_class: 'caret-down')
             .dropdown-menu.dropdown-menu-right
@@ -61,7 +64,7 @@
           - if header_link?(:user_dropdown)
             %li.nav-item.header-user.js-nav-user-dropdown.dropdown{ data: { track_label: "profile_dropdown", track_event: "click_dropdown", track_value: "", qa_selector: 'user_menu' }, class: ('mr-0' if has_impersonation_link) }
               = link_to current_user, class: user_dropdown_class, data: { toggle: "dropdown" } do
-                = image_tag avatar_icon_for_user(current_user, 23), width: 23, height: 23, class: "header-user-avatar qa-user-avatar"
+                = image_tag avatar_icon_for_user(current_user, 23), width: 23, height: 23, class: "header-user-avatar qa-user-avatar", alt: current_user.name
                 = render_if_exists 'layouts/header/user_notification_dot', project: project, namespace: group
                 = sprite_icon('angle-down', css_class: 'caret-down')
               .dropdown-menu.dropdown-menu-right

changelogs/unreleased/cngo-improve-header-accessibility.yml

+---
+title: Improve header acccessibility
+merge_request: 33603
+author:
+type: fixed