Refactor cluster metric dashboard specs

This refactors cluster metric dashboard specs by extracting some of the
shared examples into their appropriate admin/project/group spec.

ee/spec/controllers/admin/clusters_controller_spec.rb

@@ -48,6 +48,16 @@ describe Admin::ClustersController do
         end
       end
     end
+
+    describe 'GET #metrics_dashboard' do
+      let(:user) { create(:admin) }
+
+      before do
+        sign_in(user)
+      end
+
+      it_behaves_like 'the default dashboard'
+    end
   end
 
   private

ee/spec/controllers/groups/clusters_controller_spec.rb

@@ -78,6 +78,17 @@ describe Groups::ClustersController do
       it { expect { go }.to be_denied_for(:user) }
       it { expect { go }.to be_denied_for(:external) }
     end
+
+    describe 'GET #metrics_dashboard' do
+      let(:user) { create(:user) }
+
+      before do
+        clusterable.add_maintainer(user)
+        sign_in(user)
+      end
+
+      it_behaves_like 'the default dashboard'
+    end
   end
 
   private

ee/spec/controllers/projects/clusters_controller_spec.rb

@@ -70,6 +70,17 @@ describe Projects::ClustersController do
       it { expect { go }.to be_denied_for(:user) }
       it { expect { go }.to be_denied_for(:external) }
     end
+
+    describe 'GET #metrics_dashboard' do
+      let(:user) { create(:user) }
+
+      before do
+        clusterable.add_maintainer(user)
+        sign_in(user)
+      end
+
+      it_behaves_like 'the default dashboard'
+    end
   end
 
   private

ee/spec/support/shared_examples/controllers/cluster_metrics_examples.rb

@@ -186,57 +186,46 @@ shared_examples 'cluster metrics' do
         end
       end
     end
+  end
 
-    describe 'GET #metrics_dashboard' do
-      let(:user) { create(:user) }
-  
-      before do
-        clusterable.add_maintainer(user)
-        sign_in(user)
-      end
-  
-      shared_examples_for 'correctly formatted response' do |status_code|
-        it 'returns a json object with the correct keys' do
-          get :metrics_dashboard, params: metrics_params, format: :json
-  
-          found_keys = json_response.keys - ['all_dashboards']
-  
-          expect(response).to have_gitlab_http_status(status_code)
-          expect(found_keys).to contain_exactly(*expected_keys)
-        end
-      end
-  
-      shared_examples_for '200 response' do
-        let(:expected_keys) { %w(dashboard status) }
-  
-        it_behaves_like 'correctly formatted response', :ok
-      end
-  
-      shared_context 'error response' do |status_code|
-        let(:expected_keys) { %w(message status) }
-  
-        it_behaves like 'correctly formatted response', status_code
-      end
-  
-      shared_examples_for 'includes all dashboards' do
-        it 'includes info for all findable dashboards' do
-          expect(json_response).to have_key('all_dashboards')
-          expect(json_response['all_dashboards']).to be_an_instance_of(Array)
-          expect(json_response['all_dashboards']).to all( include('path', 'default', 'display_name') )
-        end
-      end
-  
-      shared_examples_for 'the default dashboard' do
-        it_behaves_like '200 response'
-  
-        it 'is the default dashboard' do
-          get :metrics_dashboard, params: metrics_params, format: :json
-  
-          expect(json_response['dashboard']['dashboard']).to eq('Cluster health')
-        end
-      end
-  
-      it_behaves_like 'the default dashboard'
+  shared_examples_for 'correctly formatted response' do |status_code|
+    it 'returns a json object with the correct keys' do
+      get :metrics_dashboard, params: metrics_params, format: :json
+
+      found_keys = json_response.keys - ['all_dashboards']
+
+      expect(response).to have_gitlab_http_status(status_code)
+      expect(found_keys).to contain_exactly(*expected_keys)
+    end
+  end
+
+  shared_examples_for '200 response' do
+    let(:expected_keys) { %w(dashboard status) }
+
+    it_behaves_like 'correctly formatted response', :ok
+  end
+
+  shared_context 'error response' do |status_code|
+    let(:expected_keys) { %w(message status) }
+
+    it_behaves like 'correctly formatted response', status_code
+  end
+
+  shared_examples_for 'includes all dashboards' do
+    it 'includes info for all findable dashboards' do
+      expect(json_response).to have_key('all_dashboards')
+      expect(json_response['all_dashboards']).to be_an_instance_of(Array)
+      expect(json_response['all_dashboards']).to all( include('path', 'default', 'display_name') )
+    end
+  end
+
+  shared_examples_for 'the default dashboard' do
+    it_behaves_like '200 response'
+
+    it 'is the default dashboard' do
+      get :metrics_dashboard, params: metrics_params, format: :json
+
+      expect(json_response['dashboard']['dashboard']).to eq('Cluster health')
     end
   end