Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6349a185
Commit
6349a185
authored
Feb 21, 2019
by
Marcia Ramos
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update code review guidelines
parent
161851de
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
doc/development/code_review.md
doc/development/code_review.md
+4
-1
No files found.
doc/development/code_review.md
View file @
6349a185
...
...
@@ -203,7 +203,10 @@ first time.
-
Extract unrelated changes and refactorings into future merge requests/issues.
-
Seek to understand the reviewer's perspective.
-
Try to respond to every comment.
-
Let the reviewer select the "Resolve discussion" buttons.
-
The merge request author resolves only the discussions they have fully
addressed. If there's an open reply, an open discussion, a suggestion,
a question, or anything else, the discussion must be left to be resolved
by the reviewer.
-
Push commits based on earlier rounds of feedback as isolated commits to the
branch. Do not squash until the branch is ready to merge. Reviewers should be
able to read individual updates based on their earlier feedback.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment