Merge branch 'pl-rubocop-inline-association-sent-notifications' into 'master'

Fix cop FactoryBot/InlineAssociation for sent notification

See merge request gitlab-org/gitlab!48153

.rubocop_manual_todo.yml

@@ -16,7 +16,6 @@ FactoryBot/InlineAssociation:
     - 'spec/factories/import_export_uploads.rb'
     - 'spec/factories/merge_requests.rb'
     - 'spec/factories/notes.rb'
-    - 'spec/factories/sent_notifications.rb'
     - 'spec/factories/uploads.rb'
     - 'spec/factories/wiki_pages.rb'
 

spec/factories/sent_notifications.rb

@@ -4,7 +4,7 @@ FactoryBot.define do
   factory :sent_notification do
     project
     recipient { project.creator }
-    noteable { create(:issue, project: project) }
+    noteable { association(:issue, project: project) }
     reply_key { SentNotification.reply_key }
   end
 end