Merge branch '204741-migrate-fa-spinner-to-spinner-within-app-views-shared-boards' into 'master'

Migrate '.fa-spinner' to '.spinner' within 'app/views/shared/boards'

See merge request gitlab-org/gitlab!36436

app/views/shared/boards/_show.html.haml

@@ -32,7 +32,7 @@
   - else
     .boards-list.w-100.py-3.px-2.text-nowrap{ data: { qa_selector: "boards_list" } }
       .boards-app-loading.w-100.text-center{ "v-if" => "loading" }
-        = icon("spinner spin 2x")
+        = loading_icon(css_class: 'gl-mb-3')
       %board{ "v-cloak" => "true",
         "v-for" => "list in state.lists",
         "ref" => "board",

app/views/shared/boards/components/sidebar/_due_date.html.haml

 .block.due_date
-  .title
+  .title.gl-h-5.gl-display-flex.gl-align-items-center
     = _("Due date")
     - if can_admin_issue?
-      = icon("spinner spin", class: "block-loading")
-      = link_to _("Edit"), "#", class: "js-sidebar-dropdown-toggle edit-link float-right"
+      = loading_icon(css_class: 'gl-ml-2 block-loading')
+      = link_to _("Edit"), "#", class: "js-sidebar-dropdown-toggle edit-link gl-ml-auto"
   .value
     .value-content
       %span.no-value{ "v-if" => "!issue.dueDate" }

app/views/shared/boards/components/sidebar/_labels.html.haml

 .block.labels
-  .title
+  .title.gl-h-5.gl-display-flex.gl-align-items-center
     = _("Labels")
     - if can_admin_issue?
-      = icon("spinner spin", class: "block-loading")
-      = link_to _("Edit"), "#", class: "js-sidebar-dropdown-toggle edit-link float-right"
+      = loading_icon(css_class: 'gl-ml-2 block-loading')
+      = link_to _("Edit"), "#", class: "js-sidebar-dropdown-toggle edit-link gl-ml-auto"
   .value.issuable-show-labels.dont-hide
     %span.no-value{ "v-if" => "issue.labels && issue.labels.length === 0" }
       = _("None")

app/views/shared/boards/components/sidebar/_milestone.html.haml

 .block.milestone
-  .title
+  .title.gl-h-5.gl-display-flex.gl-align-items-center
     = _("Milestone")
     - if can_admin_issue?
-      = icon("spinner spin", class: "block-loading")
-      = link_to _("Edit"), "#", class: "js-sidebar-dropdown-toggle edit-link float-right"
+      = loading_icon(css_class: 'gl-ml-2 block-loading')
+      = link_to _("Edit"), "#", class: "js-sidebar-dropdown-toggle edit-link gl-ml-auto"
   .value
     %span.no-value{ "v-if" => "!issue.milestone" }
       = _("None")

changelogs/unreleased/204741-migrate-fa-spinner-to-spinner-within-app-views-shared-boards.yml

+---
+title: Migrate '.fa-spinner' to `gl-loading-icon` within shared boards haml
+merge_request: 36436
+author:
+type: changed